Skip to content

Update Swap-AzureRmWebAppSlot cmdlet to use a common verb name #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2016

Conversation

markcowl
Copy link
Member

@markcowl markcowl commented Sep 23, 2016

Comments

Update Swap-AzureWebAppSlot cmdlet to use approved verb. Add alias to prevent breaking change.

This checklist is used to make sure that common issues in a pull request are covered by the creator. You can find a more complete discussion of PowerShell cmdlet best practices here.

Below in Overall Changes, check off the boxes that apply to your PR. For the categories that you did not check off, you can remove them from this body. Within each of the categories that you did select, make sure that you can check off all of the boxes.

For information on cleaning up the commits in your pull request, click here.

Overall Changes

General

  • Title of the PR is clear and informative
  • There are a small number of commits that each have an informative message
  • If it applies, references the bug/issue that the PR fixes
  • All files have the Microsoft copyright header
  • Cmdlets refer to management libraries through nuget references - no dlls are checked in
  • The PR does not introduce breaking changes (unless a major version change occurs in the assembly and module)

@markcowl
Copy link
Member Author

@naveedaz
Copy link
Contributor

Looks good.

Copy link

@nking-1 nking-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good

@akurmi
Copy link
Contributor

akurmi commented Sep 23, 2016

Looks good to me as well.

@cormacpayne cormacpayne merged commit 3c31b93 into Azure:release-3.0.0 Sep 23, 2016
@markcowl markcowl deleted the release-3.0.0 branch August 24, 2018 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants