Skip to content

Fix storage account name hardcoded in diagnostics test files #3049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2016

Conversation

zhencui
Copy link
Contributor

@zhencui zhencui commented Oct 6, 2016

Comments


Overall Changes

Tests

  • [ x ] PR includes test coverage for the included changes
  • [ x ] Tests must use xunit, and should either use Moq to mock management client calls, or use the scenario test framework
  • [ x ] PowerShell scripts used in tests must not use hard-coded values for location
  • [ x ] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for existing resources
  • [ x ] Tests should not use App.config files for settings
  • [ x ] Tests should use the built-in PowerShell functions for generating random names when unique names are necessary - this will store names in the test recording
  • [ x ] Tests should use Start-Sleep to pause rather than Thread.Sleep

@azurecla
Copy link

azurecla commented Oct 6, 2016

Hi @zhencui, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (zhencui). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@markcowl markcowl merged commit 210a9a8 into Azure:dev Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants