Fix issue with extension id containing dot

[arsnyder16]

fixes #72

[azuresdkci]

Can one of the admins verify this patch?

[azurecla]

Hi @arsnyder16, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

[azuresdkci]

Can one of the admins verify this patch?

[ogail]

@arsnyder16 we are not working on the public repo for the moment

[markcowl]

@arsnyder16 Changes for sprint 47 and sprint 48 are going agsint the private repo

[markcowl]

@arsnyder16 Apologies, I thought you had access to the private repo. Will open this PR against the private repo for you and have the team review it - this will ensure the fix goes out in the earliest possible release.

[rajinders]

I was wondering when this fix will be tested and released soon. We have two clients that are using SDK 2.5 and both of them have cloud service names with . in them. We use continuous integration so applying diagnostics extension is critical for us.

Thanks

[huangpf]

@rajinders Can you try the latest release 0.9.0? @markcowl already patched the code there.

Thanks.

[rajinders]

@huangpf @markcowl Thank you so much for fixing this issue in 0.9.0
I have tested it and it is working.
I had debugging turned on while running the cmdlets but I found the script ran slow. I had 3 roles types in my project. I tested updating diagonstics extension for each of them. Here is how i tested:

1. remove the old extension
2. updated the cloud service deployment
3. sequentially applied diagnostics extension.

everything worked but it took more than 20 minutes. I was in Central US.
This seems a bit slow.
Is there is a better way to update diagnostics extension?
Should I be using Async(start job) in PowerShell?
Will I run into any type of locking issues if I try to run the diagnostics updates to different roles at the same time?

I have two different applications that will implement this to get ready for testing on Monday so any suggestion you have will be much appreciated.