-
Notifications
You must be signed in to change notification settings - Fork 4k
Add change log for each service #3085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…change log, and updated psd1 release notes
…s in psd1 file, other minor issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can use Test_moduelManifest to get manifest information and Update-ModuleManifest to update it, we should. One textual change, otherwise this looks great.
@@ -104,6 +105,16 @@ If splitting up the pull request is not an option, we recommend **creating indiv | |||
|
|||
For more information on cleaning up the commits in a pull request, such as how to rebase, squash, and cherry-pick, click [here](./documentation/cleaning-up-commits.md). | |||
|
|||
#### Updating the change log | |||
|
|||
Any large changes that are made to a service must be reflected in the respecitve change log. This change log will allow customers to easily track what has been changed between releases of a service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any public API changes...
|
||
# The size of the new file will be everything in the array we got from | ||
# UpdateServiceChangeLog, except we exclude the last line (which is assumed to be blank) | ||
$size = $content.Length + $ChangeLogContent.Length - 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we cannot use Update-ModuleManifest?
<# | ||
This function will use the psd1 file to grab the module version. | ||
#> | ||
function GetModuleVersion([string]$PathToModule) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason we can't use Test-ModuleManifest
Description
Fix for issue #3027
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThrough
parameter.Cmdlet Parameter Guidelines