Add StaticAnalysis rule to fail cmdlets not using approved verbs

[cormacpayne]

Description

Fix for issue #3004

• Add list of approved PowerShell verbs
• Add rule that will fail if a cmdlet is not using an approved verb
• Add tests for the new rule

---

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

• I have read the contribution guidelines.

General Guidelines

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
• The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

• Pull request includes test coverage for the included changes.
• PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

• New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
• Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThrough parameter.

Cmdlet Parameter Guidelines

• Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
• Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
• Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

[cormacpayne]

@shahabhijeet any other comments?

[shahabhijeet]

Rather can we dynamically get this list. Because when the list of approved verbs change, we will have to update this list manually.
How about hydrating the list as below
PowerShell ps = PowerShell.Create();
ps.AddCommand("get-verb");
var cmdletResult = ps.Invoke();

        foreach (PSObject result in cmdletResult)
        {
            Console.WriteLine(result.Members["Verb"].Value.ToString());
        }

[markcowl]

On demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1254/

LGTM once the on-demand run passes.

[markcowl]

@cormacpayne Looks like the on-demand run fails due to the new test. See the log for the on-demand run

[cormacpayne]

Edit: on-demand here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1267/

[cormacpayne]

@markcowl @shahabhijeet adding a "Do Not Merge" tag on this PR.

Previously, the test AddVerbWithoutSupportsShouldProcessParameter was failing on the on-demand job and every other test was passing.

Now, the test ForceParameterWithoutSupportsShouldProcess is failing on the on-demand job, so we need to investigate why this is happening next release.

[cormacpayne]

@markcowl @shahabhijeet would you guys mind taking a look at this PR?

[markcowl]

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1316/

LGTM once the build succeeds