-
Notifications
You must be signed in to change notification settings - Fork 4k
Fixing some piping issue. https://github.com/Azure/azure-powershell/issues/2996 #3101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @diwudd, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
Can one of the admins verify this patch? |
@diwudd can we please add a scenario test for this? |
@azuresdkci add to whitelist |
@vivsriaus can you review this change |
@azuresdkci retest this please |
@azuresdkci retest this please |
|
||
[Fact] | ||
[Trait(Category.AcceptanceType, Category.CheckIn)] | ||
public void TestRemoveAResourceTest() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the change covered by these two test cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the scenario test I added and recorded.
LGTM |
@TianoMS Hey Tian, do you sign-off on these changes? |
@cormacpayne Signed off. |
on demand run here:http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1255/ LGTM once the on-demand build passes |
Description
The issue was when removing a set of resources, if one of operations failed, the following ones also failed because the "cancellationSource" was set to null by the first failed operation. By reinitializing "cancellationSource", we make the operations "stateless" even in pipeline.
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThrough
parameter.Cmdlet Parameter Guidelines