Skip to content

Fixing some piping issue. https://github.com/Azure/azure-powershell/issues/2996 #3101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 26, 2016

Conversation

diwudd
Copy link
Contributor

@diwudd diwudd commented Oct 19, 2016

Description

The issue was when removing a set of resources, if one of operations failed, the following ones also failed because the "cancellationSource" was set to null by the first failed operation. By reinitializing "cancellationSource", we make the operations "stateless" even in pipeline.


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThrough parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@azurecla
Copy link

Hi @diwudd, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (wud). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci
Copy link

Can one of the admins verify this patch?

@vivsriaus
Copy link
Contributor

@diwudd can we please add a scenario test for this?

@shahabhijeet
Copy link
Contributor

@azuresdkci add to whitelist

@shahabhijeet shahabhijeet self-assigned this Oct 21, 2016
@shahabhijeet
Copy link
Contributor

@vivsriaus can you review this change

@vivsriaus
Copy link
Contributor

@azuresdkci retest this please

@diwudd
Copy link
Contributor Author

diwudd commented Oct 24, 2016

@azuresdkci retest this please


[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestRemoveAResourceTest()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change covered by these two test cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the scenario test I added and recorded.

@vivsriaus
Copy link
Contributor

LGTM

@cormacpayne
Copy link
Member

@TianoMS Hey Tian, do you sign-off on these changes?

@TianoMS
Copy link

TianoMS commented Oct 25, 2016

@cormacpayne Signed off.

@markcowl
Copy link
Member

on demand run here:http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1255/

LGTM once the on-demand build passes

@markcowl markcowl merged commit e2b100e into Azure:dev Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants