Support creating Spark 2.0 cluster using Azure HDInsight PowerShell #3110

iyerrb · 2016-10-21T23:07:27Z

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThrough parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.
version of a service. Added a new cmdlet
Add-AzureRmHDInsightComponentVersion to specify the component version of
the service during cluster creation. Get-AzureRmHDInsightCluster cmdlet
will also return the component version of the service if specified during
cluster creation

version of a service. Added a new cmdlet Add-AzureRmHDInsightComponentVersion to specify the component version of the service during cluster creation. Get-AzureRmHDInsightCluster cmdlet will also return the component version of the service if specified during cluster creation

azurecla · 2016-10-21T23:07:42Z

Hi @iyerrb, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (riyer). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

azuresdkci · 2016-10-21T23:10:19Z

Can one of the admins verify this patch?

cormacpayne · 2016-10-24T17:46:11Z

@azuresdkci add to whitelist

cormacpayne · 2016-10-24T21:26:53Z

@iyerrb Hey Rajesh, the build is failing because the cmdlet Add-AzureRmHDInsightComponentVersion does not implement ShouldProcess.

You can check out the guide here on how to implement ShouldProcess.

support

markcowl · 2016-10-25T00:55:40Z

.../HDInsight/Commands.HDInsight/ManagementCommands/AddAzureHDInsightComponentVersionCommand.cs

@@ -20,7 +20,8 @@ namespace Microsoft.Azure.Commands.HDInsight
 {
    [Cmdlet(
        VerbsCommon.Add,
-        Constants.CommandNames.AzureHDInsightComponentVersion),
+        Constants.CommandNames.AzureHDInsightComponentVersion,
+        SupportsShouldProcess = true),


That is not all. You also need to either call ConfirmAction or ShoudlProcess correctly during cmdlet execution. See: https://gist.github.com/markcowl/338e16fe5c8bbf195aff9f8af0db585d

I have updated the PR with a call to ConfirmAction from the cmdlet

Do you have any more comments on this change?
Thanks

@markcowl ping

cormacpayne · 2016-10-25T16:21:17Z

.../HDInsight/Commands.HDInsight/ManagementCommands/AddAzureHDInsightComponentVersionCommand.cs

+                {
+                    Config.ComponentVersion.Add(ComponentName, ComponentVersion);
+                    WriteObject(Config);
+                })


@iyerrb the build is failing because you are missing a semicolon here

have fixed this and the other error due to 'Name' parameter in ConfirmAction

shefaliv · 2016-10-25T23:01:44Z

Can we get this merged please?

markcowl · 2016-10-26T01:03:30Z

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1251/

markcowl · 2016-10-26T01:08:09Z

.../HDInsight/Commands.HDInsight/ManagementCommands/AddAzureHDInsightComponentVersionCommand.cs

@@ -47,12 +47,12 @@ public class AddAzureHDInsightComponentVersionCommand : HDInsightCmdletBase

        public override void ExecuteCmdlet()
        {
-            ConfirmAction("Adding Component Version", Name,
+            ConfirmAction("Adding Component Version", "AzureHDInsightConfig",


Should this be 'ComponentName'?

No, the resource being modified is the AzureHDInsightConfig because there's no ComponentName object

I have attached a picture of the confirm action prompt for this cmdlet.

iyerrb · 2016-10-26T16:55:20Z

Is today the cutoff to get on the next release train due next Tuesday (first Tuesday of the month?)

iyerrb · 2016-10-26T21:37:31Z

I wanted to update my manager whether this change will be shipped next week or next month. Kindly let me know the ship date for this change.

cormacpayne · 2016-10-26T22:07:21Z

@iyerrb this will be shipped next Wednesday for the November release of Azure PowerShell

itaysk · 2016-11-18T18:10:09Z

What's the -ComponentVersion parameter on the New-AzureRmHDInsightCluster cmdlet? How can we populate it instead of using the dedicated cmdlet?

azurecla added the cla-not-required label Oct 21, 2016

Updated packages.config to use the latest HDInsight SDK version

6ccc667

Updated Add-AzureRmHDInsightComponentVersion cmdlet with ShouldProcess

4952670

support

markcowl requested changes Oct 25, 2016

View reviewed changes

Added ConfirmAction to Add-AzureRmHDInsightComponentVersion cmdlet

245e738

cormacpayne reviewed Oct 25, 2016

View reviewed changes

Fix build breaks

056de9c

markcowl requested changes Oct 26, 2016

View reviewed changes

markcowl self-assigned this Oct 26, 2016

markcowl approved these changes Oct 26, 2016

View reviewed changes

markcowl merged commit 3c33667 into Azure:dev Oct 26, 2016

Support creating Spark 2.0 cluster using Azure HDInsight PowerShell #3110

Support creating Spark 2.0 cluster using Azure HDInsight PowerShell #3110

Uh oh!

Conversation

iyerrb commented Oct 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

azurecla commented Oct 21, 2016

Uh oh!

azuresdkci commented Oct 21, 2016

Uh oh!

cormacpayne commented Oct 24, 2016

Uh oh!

cormacpayne commented Oct 24, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shefaliv commented Oct 25, 2016

Uh oh!

markcowl commented Oct 26, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iyerrb commented Oct 26, 2016

Uh oh!

iyerrb commented Oct 26, 2016

Uh oh!

cormacpayne commented Oct 26, 2016

Uh oh!

itaysk commented Nov 18, 2016

Uh oh!

Uh oh!

iyerrb commented Oct 21, 2016 •

edited

Loading