Adding PsVersion to userAgent #3154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is should only happen while running tests. Fixing misspell file. Adding test for the psVersion userAgent string.
|
Started on-demand build |
…or to cmdlet processing and then asserting on the actual count. On CI the initial count was more than zero, but locally it is alwasy zero
markcowl
requested changes
Oct 28, 2016
| @@ -41,6 +44,41 @@ public LoginCmdletTests(ITestOutputHelper output) | |||
| } | |||
|
|
|||
| [Fact] | |||
| [Trait(Category.RunType, Category.CheckIn)] | |||
There was a problem hiding this comment.
If you make the first trait Category.AcceptanceType, this will run as part of check-in
|
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1282/ LGTM once the on-demand run passes. |
markcowl
approved these changes
Oct 28, 2016
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding PsVersion to userAgent, defaulting to v3.0 if Host is null, this should only happen while running tests. Fixing misspell file. Adding test for the psVersion userAgent string.