1. Added new new param:TunnelConnectionStatus in output object:VirtualNetworkGatewayConnection and 2. Added new optional input param:gatewayVip in ResetGateway API. #3170
Conversation
…lNetworkGatewayConnection and 2. Added new optional input param:gatewayVip in ResetGateway API.
|
@markcowl Can you help accept this PR? Thanks a lot! |
| @@ -44,7 +44,7 @@ public class ResetAzureVirtualNetworkGatewayConnectionSharedKeyCommand : Virtual | |||
| ValueFromPipelineByPropertyName = true, | |||
| HelpMessage = "The virtual network connection reset shared key length")] | |||
| [ValidateNotNullOrEmpty] | |||
| public uint KeyLength { get; set; } | |||
| public int KeyLength { get; set; } | |||
There was a problem hiding this comment.
int [](start = 15, length = 3)
Can you clarify why changing it to int helps in this case, because no matter what datatype you end up using, the user cannot provide a key length value more than 4 billion (or whatever the upper limit is)
Unless you support a scenario where a user can provide key length in negative value?
There was a problem hiding this comment.
As per suggestions in rest api spec, we have made some fixes, this was also part of that. No specific purpose.
There was a problem hiding this comment.
As we talked offline, please revert this change and update the PR
In reply to: 86872966 [](ancestors = 86872966)
There was a problem hiding this comment.
Reverted back as per offline discussion,
| @@ -41,6 +42,8 @@ public class PSVirtualNetworkGatewayConnection : PSTopLevelResource | |||
|
|
|||
| public ulong IngressBytesTransferred { get; set; } | |||
|
|
|||
| public List<PSTunnelConnectionHealth> TunnelConnectionStatus { get; set; } | |||
There was a problem hiding this comment.
I don't see any test coverage for this functionality.
There was a problem hiding this comment.
Updating test to cover this.
| Mandatory = false, | ||
| ValueFromPipeline = true, | ||
| HelpMessage = "The gateway vip in order to reset particular gateway instance (e.g. in case of Active-Active feature enabled gateways.) By default, gateway primary instance will be reset if no value is passed.")] | ||
| public string GatewayVip { get; set; } |
There was a problem hiding this comment.
I don't see any test coverage for this.
There was a problem hiding this comment.
Updating test to cover this.
| { | ||
| using System; | ||
|
|
||
| public class PSTunnelConnectionHealth |
There was a problem hiding this comment.
PSTunnelConnectionHealth [](start = 17, length = 24)
please follow the comments in the respective RP directory and submit your changelog
src/ResourceManager//ChangeLog.md
| @@ -19,10 +19,9 @@ | |||
| --> | |||
| ## Current Release | |||
|
|
|||
| ## Version 3.1.0 | |||
There was a problem hiding this comment.
@Nilambari Hey Nilambari, please keep the information corresponding to release 3.1.0 in the change log so that customers looking at the change log can follow changes across multiple releases. Also, please move the information under "Version 3.2.0" to under "Current Release". At the end of the release, we run a script that will move the contents from under "Current Release" and put them under a newly created release section (in this case, 3.2.0).
|
Can you Please help accept the PR? Thanks! |
This PR contains 2 changes :-
object to show per tunnel connection health status. It is used in comment let:- Get-AzureRmVirtualNetworkGatewayConnection
-Active feature enabled gateways.