Decoupling Azurestack admin from AzureRM.psd1

[bganapa]

Description

---

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

• I have read the contribution guidelines.
• If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
• If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
• The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

• Pull request includes test coverage for the included changes.
• PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

• New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
• Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThrough parameter.

Cmdlet Parameter Guidelines

• Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
• Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
• Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

[bganapa]

@markcowl This PR needs your feedback as it affects the publishing process

[markcowl]

One change, also there are merge conflicts

[markcowl]

I don't think this is the right way to do this. This function shouldn't be called on the AzureStack module, so that is where the change should be made

[bganapa]

@markcowl The function change-rmmodule in addition to adding psm1 dependency, it also packages and publishes the module to local temp repo. So the function needs to be called for azurestack as well. could you please check?

[markcowl]

@bganapa It isn't run against AzureRM, it would only need to be run for a module that contained dlls, not a wrapper module, which only included other modules

[bganapa]

@markcowl Change-RMModule is also run for AzureRM, Am I missing something?

[markcowl]

@bganapa There are merge conflicts, please update

[bganapa]

@markcowl made the changes as requested, pls review

[cormacpayne]

@markcowl any other comments?

[markcowl]

A couple of minor issues, please fix. I'm going to run a signing job to ensure that this creates the right packages as well.

[markcowl]

Plerase fix the spacing here

[bganapa]

Fixed the spacing

[markcowl]

Why move this?

[bganapa]

param needs to be at the beginning to e recongnized as params atleast on my box :). leaving it as such

[markcowl]

signign build here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/698/

Signing build of just AzureStack here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/699/

[markcowl]

Closing in favor of #2567