-
Notifications
You must be signed in to change notification settings - Fork 4k
Merge Changes to implement Read Scale feature for Azure Sql DB #3212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @ziwa-msft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
Can one of the admins verify this patch? |
@akromm @yoavrubin @jamestao Can one of you approve the changes. @ziwa-msft Please update the changelog here: https://github.com/Azure/azure-powershell/blob/dev/src/ResourceManager/Sql/ChangeLog.md to descibe the changes in the current release. This should specifically list the cmdlets affected and the new functionality added. |
@azuresdkci add to whitelist |
@ziwa-msft can you address the CI failures. |
@markcowl any other changes? |
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1319/ LGTM once the build passes |
@markcowl @cormacpayne Thank you for your help on getting this project merged on time :) |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThrough
parameter.Cmdlet Parameter Guidelines