Skip to content

Improve error message when using MSA with -Credential parameter #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2016

Conversation

cormacpayne
Copy link
Member

@cormacpayne cormacpayne commented Dec 6, 2016

Description

Fix for issue #3121

Previously, when a user tried to login with a Microsoft Account and the -Credential parameter, the following error would be thrown:

Login-AzureRmAccount: Sequence contains no elements

Now, a more meaningful error will be thrown in the same case:

Login-AzureRmAccount : -Credential parameter can only be used with Organization ID credentials. For more information,
please refer to http://go.microsoft.com/fwlink/?linkid=331007&clcid=0x409 for more information about the difference
between an organizational account and a Microsoft account.

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThrough parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.
    …g the Credential parameter

@cormacpayne
Copy link
Member Author

cormacpayne commented Dec 6, 2016

@markcowl
Copy link
Member

markcowl commented Dec 6, 2016

Tests? Please add a LiveOnly test for this scenario

@cormacpayne
Copy link
Member Author

@simeyla
Copy link

simeyla commented Feb 19, 2018

This still occurs with Connect-AzureRmAccount -TenantId $tenantid -Credential $cred after just updating AzureRM today. How come? Very confusing error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants