Support ResourceGroupNameEquals and ResourceNameEquals as parameters in Find-AzureRmResource #3257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Find-AzureRmResource.
vivsriaus
reviewed
Dec 7, 2016
| /// <param name="resourceGroup">The name of the resource group/</param> | ||
| /// <param name="resourceType">The resource type.</param> | ||
| /// <param name="resourceName">The resource name.</param> | ||
| /// <param name="tagName">The tag name.</param> | ||
| /// <param name="tagValue">The tag value.</param> | ||
| /// <param name="filter">The filter.</param> | ||
| public static string CreateFilter( | ||
| Guid[] subscriptionIds, |
There was a problem hiding this comment.
Why are we removing the support for multiple subIds?
There was a problem hiding this comment.
we don't have any scenario that has mutiple subsIds in our repo now.
vivsriaus
reviewed
Dec 7, 2016
| /// </summary> | ||
| private bool ResourceGroupNameAvailable() | ||
| { | ||
| return this.ResourceGroupNameContains != null || this.ResourceGroupNameEquals != null; |
There was a problem hiding this comment.
string.IsNullOrEmpty is better here, no?
There was a problem hiding this comment.
Seems we have been doing null check for all parameters. I think we can keep it consistent.
|
LGTM thanks! @markcowl @cormacpayne |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcessand haveSupportShouldProcess=truespecified in the cmdlet attribute. You can find more information onShouldProcesshere.OutputTypeattribute if any output is produced - if the cmdlet produces no output, it should implement aPassThroughparameter.Cmdlet Parameter Guidelines
…in Find-AzureRmResource.