ADL Updates to use latest GA packages. #3261
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,7 @@ | |
|
|
||
| namespace Microsoft.Azure.Commands.DataLakeAnalytics | ||
| { | ||
| [Cmdlet(VerbsCommon.Set, "AzureRmDataLakeAnalyticsAccount"), OutputType(typeof(PSDataLakeAnalyticsAccount))] | ||
| [Alias("Set-AdlAnalyticsAccount")] | ||
| public class SetAzureDataLakeAnalyticsAccount : DataLakeAnalyticsCmdletBase | ||
| { | ||
|
|
@@ -29,36 +29,39 @@ public class SetAzureDataLakeAnalyticsAccount : DataLakeAnalyticsCmdletBase | |
| public string Name { get; set; } | ||
|
|
||
| [Parameter(ValueFromPipelineByPropertyName = true, Position = 1, Mandatory = false, | ||
| HelpMessage = | ||
| "A string,string dictionary of tags associated with this account that should replace the current set of tags" | ||
| )] | ||
| [ValidateNotNull] | ||
|
There was a problem hiding this comment. @begoldsm why is this parameter being remove? This is a breaking change There was a problem hiding this comment. Was never supported. Same comment as above. We were lucky no one tried to use this option, since it would have always resulted in an exception from the server saying "changes to default store are not allowed" |
||
| public Hashtable Tags { get; set; } | ||
|
|
||
| [Parameter(ValueFromPipelineByPropertyName = true, Position = 2, Mandatory = false, | ||
|
There was a problem hiding this comment. @begoldsm same comment about too many positional parameters |
||
| HelpMessage = "Name of resource group under which you want to update the account.")] | ||
| [ValidateNotNullOrEmpty] | ||
| public string ResourceGroupName { get; set; } | ||
|
|
||
| [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, | ||
| HelpMessage = "The maximum supported degree of parallelism for this account.")] | ||
| [ValidateNotNull] | ||
| [ValidateRange(1, int.MaxValue)] | ||
| public int? MaxDegreeOfParallelism { get; set; } | ||
|
|
||
| [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, | ||
| HelpMessage = "The maximum supported jobs running under the account at the same time.")] | ||
| [ValidateNotNull] | ||
| [ValidateRange(1, int.MaxValue)] | ||
| public int? MaxJobCount { get; set; } | ||
|
|
||
| [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = false, | ||
| HelpMessage = "The number of days that job metadata is retained.")] | ||
| [ValidateNotNull] | ||
| [ValidateRange(1, 180)] | ||
| public int? QueryStoreRetention { get; set; } | ||
|
|
||
| public override void ExecuteCmdlet() | ||
| { | ||
| WriteObject(new PSDataLakeAnalyticsAccount(DataLakeAnalyticsClient.CreateOrUpdateAccount(ResourceGroupName, Name, null, null, | ||
| null, null, Tags, MaxDegreeOfParallelism, MaxJobCount, QueryStoreRetention))); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@begoldsm this cmdlet won't return anything anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It never returned anything. The object would be null/empty since the service has never returned anything. This was detected during the time spent adding more robust test support across our service.