Skip to content

Use a simpler filter when calling Graph in ADFS scenarios. #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2016

Conversation

adarce
Copy link
Member

@adarce adarce commented Dec 15, 2016

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThrough parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@azurecla
Copy link

Hi @adarce, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (adarce). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

jkapil
jkapil previously requested changes Dec 15, 2016
u.OtherMails.Any(m => m.Equals(upn, StringComparison.OrdinalIgnoreCase));
}

return u => u.UserPrincipalName.Equals(upn);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I fixed this.

@adarce adarce force-pushed the feature/filter-adfs branch from 03ebbb6 to c68988c Compare December 15, 2016 04:07
@adarce adarce dismissed jkapil’s stale review December 15, 2016 04:08

I addressed his feedback.

Copy link

@mtandon80 mtandon80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please validate that these changes work for both AAD and ADFS

@cormacpayne
Copy link
Member

LGTM

@cormacpayne
Copy link
Member

@adarce is this ready to be merged?

@adarce
Copy link
Member Author

adarce commented Dec 16, 2016

@cormacpayne Yes, please merge when you're ready.

@cormacpayne
Copy link
Member

@adarce merging your other PR caused a merge conflict in this PR. Please fix this issue and then we can merge.

@adarce adarce force-pushed the feature/filter-adfs branch from c68988c to 01329bf Compare December 16, 2016 20:31
@adarce
Copy link
Member Author

adarce commented Dec 16, 2016

@cormacpayne I've resolved the merge conflict, and the CI build has passed. Feel free to merge!

@cormacpayne cormacpayne merged commit 4cc130d into Azure:dev Dec 16, 2016
@adarce adarce deleted the feature/filter-adfs branch December 17, 2016 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants