-
Notifications
You must be signed in to change notification settings - Fork 4k
Use a simpler filter when calling Graph in ADFS scenarios. #3294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @adarce, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
u.OtherMails.Any(m => m.Equals(upn, StringComparison.OrdinalIgnoreCase)); | ||
} | ||
|
||
return u => u.UserPrincipalName.Equals(upn); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I fixed this.
03ebbb6
to
c68988c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please validate that these changes work for both AAD and ADFS
LGTM |
@adarce is this ready to be merged? |
@cormacpayne Yes, please merge when you're ready. |
@adarce merging your other PR caused a merge conflict in this PR. Please fix this issue and then we can merge. |
c68988c
to
01329bf
Compare
@cormacpayne I've resolved the merge conflict, and the CI build has passed. Feel free to merge! |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThrough
parameter.Cmdlet Parameter Guidelines