New parameters in New-AzureRmVMSqlServerAutoBackupConfig cmdlet to support Auto Backup for SQL Server 2016 VMs. #3313

anilkyelam · 2016-12-16T20:35:08Z

Description

Renamed New-AzureVMSqlServer* cmdlets to include "Rm" in the name. Kept the old ones for backward compatibility.
Added new parameters for New-AzureRmVMSqlServerAutoBackupConfig that reflect changes for Auto Backup V2 for SQL IaaS Extension.
Fixed bug in Get-AzureRmVMSqlServerExtension to correctly get values of parameters by parsing the substatus in the response.

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThrough parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

…mdlets on SQL14 and 16 VMs.

… appears on Portal

…lic settings in response. Fixed tests.

… manual. Added description for new parameters in help file.

…mpute.

azurecla · 2016-12-16T20:35:21Z

Hi @anilyela, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (anilyela). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

cormacpayne · 2016-12-16T22:32:28Z

...anager/Compute/Commands.Compute/Extension/SqlServer/NewAzureRmVMSqlServerAutoBackupConfig.cs

+        DefaultParameterSetName = StorageUriParamSetName),
+    OutputType(
+        typeof(AutoBackupSettings))]
+    public class NewAzureRmVMSqlServerAutoBackupConfigCommand : AzureRMCmdlet


@anilyela if you are changing the name of the cmdlet New-AzureVMSqlServerAutoBackupConfig to New-AzureRmVMSqlServerAutoBackupConfig, you do not need to add an entirely new file - you can add an alias in the old cmdlet to New-AzureRmVMSqlServerAutoBackupConfig. There does not need to be separate files for the same cmdlet.

done, thanks!

cormacpayne · 2016-12-16T22:33:29Z

...ager/Compute/Commands.Compute/Extension/SqlServer/NewAzureRmVMSqlServerAutoPatchingConfig.cs

+         ProfileNouns.VirtualMachineSqlServerAutoPatchingConfig),
+     OutputType(
+         typeof(AutoPatchingSettings))]
+    public class NewAzureRmVMSqlServerAutoPatchingConfigCommand : PSCmdlet


@anilyela same comment about adding alias

cormacpayne · 2016-12-16T22:33:44Z

...ompute/Commands.Compute/Extension/SqlServer/NewAzureRmVMSqlServerKeyVaultCredentialConfig.cs

+         SupportsShouldProcess = true),
+     OutputType(
+         typeof(KeyVaultCredentialSettings))]
+    public class NewAzureRmVMSqlServerKeyVaultCredentialConfigCommand : PSCmdlet


@anilyela same comment about adding alias

…. Modified help file accordingly.

cormacpayne

@anilyela a few comments

cormacpayne · 2016-12-21T17:21:57Z

...eManager/Compute/Commands.Compute/Extension/SqlServer/NewAzureVMSqlServerAutoBackupConfig.cs

@@ -117,6 +120,77 @@ public SecureString StorageKey
            set;
        }

+        [Parameter(
+          Mandatory = false,
+          Position = 6,


@anilyela we ask that there be no more than four positional parameters for a cmdlet. Please remove the position attribute from the parameters you have added to this cmdlet.

cormacpayne · 2016-12-21T17:26:11Z

src/ResourceManager/Compute/ChangeLog.md

@@ -18,6 +18,8 @@
        - Additional information about change #1
 -->
 ## Current Release
+* New parameters in New-AzureRmVMSqlServerAutoBackupConfig cmdlet to support Auto Backup for SQL Server 2016 VMs.
+* New-AzureVMSqlServer* cmdlets are renamed to New-AzureRmVMSqlServer* now. Old ones will continue to work however.


@anilyela for the change log, can you talk about the new parameters in New-AzureRmVMSqlServerAutoBackupConfig?

* New parameters in ... - BackupSystemDbs: < brief description> - BackupScheduleType: <brief description>

Added more detail

…changelog.

anilkyelam · 2016-12-22T00:21:37Z

@cormacpayne addressed your comments.

cormacpayne · 2016-12-22T17:20:41Z

@anilyela are there any more sign-offs you are waiting on?

anilkyelam · 2016-12-22T18:58:31Z

@cormacpayne no, signoff from nimeshnedungadi is enough from our side.

anilkyelam · 2016-12-22T20:03:02Z

Thanks @cormacpayne. When is next release that takes change this live?

cormacpayne · 2016-12-22T21:57:53Z

@anilyela you can view the dates of the next three Azure PowerShell releases here

It is scheduled for January 18th

Anil Kumar Yelam added 9 commits December 1, 2016 17:19

Added new params for AutoBackup, Tests exlcluded.

4032ca8

Small fix to get the existing tests work

5235875

Retained old cmdlets for compatibility. Added deployment token. Ran c…

8c690f1

…mdlets on SQL14 and 16 VMs.

Included unit tests. Changed ExtensionPublishedName so SQL Config tab…

167dca3

… appears on Portal

Changed Get-Extension response to get values from SQL config, not pub…

95ea3ec

…lic settings in response. Fixed tests.

Adding more validation for backup settings when backupscheduletype is…

d8b54f2

… manual. Added description for new parameters in help file.

Merge branch 'dev-GetExtensionWrongResponseBug' into dev

0b1378e

Merging with upstream

b77b65c

Help xml regenerated using platyPSHelp. Edited changelog for Azure.Co…

2b12961

…mpute.

azurecla added the cla-not-required label Dec 16, 2016

anilkyelam requested review from hovsepm, nimeshnedungadi and michaelcohenmicrosoft December 16, 2016 20:36

cormacpayne suggested changes Dec 16, 2016

View reviewed changes

Used Alias attribute to rename commands instead of adding new cmdlets…

8e4741e

…. Modified help file accordingly.

nimeshnedungadi approved these changes Dec 20, 2016

View reviewed changes

cormacpayne suggested changes Dec 21, 2016

View reviewed changes

cormacpayne added the Changes Requested label Dec 21, 2016

Removed position attributes for new parameters. Added more detail in …

74defc4

…changelog.

cormacpayne approved these changes Dec 22, 2016

View reviewed changes

cormacpayne merged commit 2075329 into Azure:dev Dec 22, 2016

New parameters in New-AzureRmVMSqlServerAutoBackupConfig cmdlet to support Auto Backup for SQL Server 2016 VMs. #3313

New parameters in New-AzureRmVMSqlServerAutoBackupConfig cmdlet to support Auto Backup for SQL Server 2016 VMs. #3313

Uh oh!

Conversation

anilkyelam commented Dec 16, 2016

Description

Uh oh!

azurecla commented Dec 16, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anilkyelam commented Dec 22, 2016

Uh oh!

cormacpayne commented Dec 22, 2016

Uh oh!

anilkyelam commented Dec 22, 2016

Uh oh!

anilkyelam commented Dec 22, 2016

Uh oh!

cormacpayne commented Dec 22, 2016

Uh oh!

Uh oh!