Skip to content

Fix usability bugs in Get-AzureRmOperationalInsightsSearchResults #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2017
Merged

Fix usability bugs in Get-AzureRmOperationalInsightsSearchResults #3343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5613a0
Improve Get-AzureRmOperationalInsightsSearchResults cmdlet
pilor Jan 3, 2017
94f2f2a
Revert nullable Top parameter type change
pilor Jan 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ResourceManager/OperationalInsights/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
- Additional information about change #1
-->
## Current Release
* Get-AzureRmOperationalInsightsSearchResults no longer requires the Top parameter to retrieve results

## Version 2.4.0

Expand Down
4 changes: 2 additions & 2 deletions ...tionalInsights/Commands.OperationalInsights.Test/Commands.OperationalInsights.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@
<None Include="SessionRecords\Microsoft.Azure.Commands.OperationalInsights.Test.SearchTests\TestSearchSetAndRemoveSavedSearches.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.Azure.Commands.OperationalInsights.Test.StorageInsightTests\TestStorageInsightCreateFailsWithoutWorkspace.json">
<None Include="SessionRecords\Microsoft.Azure.Commands.OperationalInsights.Test.StorageInsightTests\TestStorageInsightCreateFailsNoWs.json">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="SessionRecords\Microsoft.Azure.Commands.OperationalInsights.Test.StorageInsightTests\TestStorageInsightCreateUpdateDelete.json">
Expand All @@ -243,4 +243,4 @@
</ItemGroup>
<ItemGroup />
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
</Project>
</Project>
4 changes: 2 additions & 2 deletions ...perationalInsights/Commands.OperationalInsights.Test/ScenarioTests/StorageInsightTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ public void TestStorageInsightCreateUpdateDelete()

[Fact]
[Trait(Category.AcceptanceType, Category.CheckIn)]
public void TestStorageInsightCreateFailsWithoutWorkspace()
public void TestStorageInsightCreateFailsNoWs()
{
RunPowerShellTest("Test-StorageInsightCreateFailsWithoutWorkspace");
RunPowerShellTest("Test-StorageInsightCreateFailsNoWs");
}
}
}
2 changes: 1 addition & 1 deletion ...erationalInsights/Commands.OperationalInsights.Test/ScenarioTests/StorageInsightTests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ function Test-StorageInsightCreateUpdateDelete
.SYNOPSIS
Validate that storage insight creation fails without a valid parent workspace
#>
function Test-StorageInsightCreateFailsWithoutWorkspace
function Test-StorageInsightCreateFailsNoWs
{
$wsname = Get-ResourceName
$siname = Get-ResourceName
Expand Down
2 changes: 1 addition & 1 deletion ...geInsightCreateFailsWithoutWorkspace.json → ...ts/TestStorageInsightCreateFailsNoWs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@
}
],
"Names": {
"Test-StorageInsightCreateFailsWithoutWorkspace": [
"Test-StorageInsightCreateFailsNoWs": [
"onesdk4327",
"onesdk2618",
"onesdk7042",
Expand Down
6 changes: 4 additions & 2 deletions ...erationalInsights/Commands.OperationalInsights/Client/OperationalInsightsClient.Search.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,18 @@ public virtual PSSearchGetSchemaResponse GetSchema(string resourceGroupName, str
public virtual PSSearchGetSearchResultsResponse GetSearchResults(string resourceGroupName, string workspaceName, PSSearchGetSearchResultsParameters psParameters)
{
SearchGetSearchResultsParameters parameters = new SearchGetSearchResultsParameters();
parameters.Top = psParameters.Top;

if (psParameters.Highlight != null)
{
parameters.Highlight = new Highlight();
parameters.Highlight.Pre = psParameters.Highlight.Pre;
parameters.Highlight.Post = psParameters.Highlight.Post;
}

parameters.Top = psParameters.Top == 0 ? 10 : psParameters.Top;
parameters.Query = psParameters.Query;
parameters.Start = psParameters.Start;
parameters.End = psParameters.End;
parameters.End = psParameters.End.GetValueOrDefault(DateTime.UtcNow);

SearchGetSearchResultsResponse response = OperationalInsightsManagementClient.Search.GetSearchResults(resourceGroupName, workspaceName, parameters);
PSSearchGetSearchResultsResponse searchResponse = new PSSearchGetSearchResultsResponse(response);
Expand Down
Loading