Skip to content

ServiceBus - Included format.ps1xml for Sku property #3359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2017

Conversation

v-Ajnava
Copy link

@v-Ajnava v-Ajnava commented Jan 6, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azurecla
Copy link

azurecla commented Jan 6, 2017

Hi @v-Ajnava, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (v-ajnava). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@shahabhijeet
Copy link
Contributor

@v-Ajnava please add more information for the PR as to what is the purpose of this PR. Clean up the description template and use what is applicable from the template.

@shahabhijeet
Copy link
Contributor

@v-Ajnava please add appropriate folks from your team who sign off will be required for this PR.

@v-Ajnava v-Ajnava requested a review from sazeesha January 9, 2017 22:50
@sazeesha
Copy link
Contributor

sazeesha commented Jan 9, 2017

@cormacpayne as we discussed it is not a breaking change. ResourceGroupName property should not have been there from the beginning.

@cormacpayne
Copy link
Member

@v-Ajnava there is a merge conflict in the change log. Once you resolve that, we can kick off an on-demand build.

@cormacpayne
Copy link
Member

@v-Ajnava there are extra commits and changes in this PR, please clean this up

@cormacpayne
Copy link
Member

@cormacpayne
Copy link
Member

LGTM once on-demand passes

@cormacpayne cormacpayne merged commit 64357a7 into Azure:dev Jan 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants