Adding Analysis Service Dataplane module to AzureRm rollup module #3382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@azuresdkci add to whitelist |
cormacpayne
reviewed
Jan 12, 2017
| @@ -54,6 +54,7 @@ CLRVersion = '4.0' | |||
| RequiredModules = @(@{ModuleName = 'AzureRM.Profile'; RequiredVersion = '2.4.0'; }, | |||
| @{ModuleName = 'Azure.Storage'; RequiredVersion = '2.4.0'; }, | |||
| @{ModuleName = 'AzureRM.AnalysisServices'; RequiredVersion = '0.0.2'}, | |||
| @{ModuleName = 'Azure.AnalysisServices'; RequiredVersion = '0.0.1'}, | |||
There was a problem hiding this comment.
@shahabhijeet can you fix the indentation for this?
cormacpayne
reviewed
Jan 12, 2017
| @@ -61,6 +61,8 @@ function Get-TargetModules | |||
| $targets += $module.FullName | |||
| } | |||
| } | |||
| $targets += "$resourceManagerRootFolder\Azure.AnalysisServices" | |||
There was a problem hiding this comment.
@shahabhijeet same comment about indentation
|
LGTM once the indentation is fixed. |
Removing extra tab that resulted in misalignment
aligning
|
@markcowl @cormacpayne it was odd that, the local file that I had do not show these misalignments. So I had to edit the file on GitHub to fix these alignment issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.