Skip to content

Fix sign build break #3383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 13, 2017
Merged

Fix sign build break #3383

merged 4 commits into from
Jan 13, 2017

Conversation

shahabhijeet
Copy link
Contributor

@shahabhijeet shahabhijeet commented Jan 12, 2017

Adding ServiceManagement Common project to RedisCache solution because it is not getting build with the same configuration during Signed build.

Why this happens:

  1. Msbuild has a bug where when trying to create a project build map (meta project) it only get's the project that are listed in the solution
  2. In this particular case, RedisCacheTest solution added project reference to Commands.Storage
  3. But Commands.Storage has project reference to ServiceManagement.Common, this causes msbuild to miss this project in it's map and hence defaults to project default properties (in this case debug)
    resulting in SM.Common project getting build as debug and hence not delayed signed and hence the entire build fails.

Copy link
Contributor

@SiddharthChatrolaMs SiddharthChatrolaMs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@markcowl
Copy link
Member

LGTM

@cormacpayne cormacpayne merged commit 980ccde into Azure:dev Jan 13, 2017
@shahabhijeet shahabhijeet deleted the fixSignBuild branch January 26, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants