Reading and passing the entire pfx file so that we also get the certi…

[vinatara]

…ficate chain (and not just the final cert). We need to install intermediate certs on the application gateway.

Description

---

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

• I have read the contribution guidelines.
• If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
• If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
• The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

• Pull request includes test coverage for the included changes.
• PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

• New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
• Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

• Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
• Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
• Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

[azurecla]

Hi @vinatara, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (vinatara). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

[puneetsaraswat]

Looks good. RDFE cmdlet also needs same fix?

[markcowl]

@vinatara Where are tests for this scenario? Also, please fill out the PR checklist above.

[cormacpayne]

@vinatara ping

[vinatara]

In this change, we are passing the whole pfx file as is, instead of the last certificate in the chain. It is difficult to add tests for this, since failure only happens in the data path of the gateway for some limited set of certs.

[markcowl]

@vinatara So the solution is to mock out the API using Moq and test this in a unit test. If you don't have time to do this in thsi release, please create an issue for the test debt and you will need to fix this before the next (post February) release.

[vinatara]

Created issue for this:
#3467