Add property State in additional to ProvisioningState #3406

shihying · 2017-01-19T00:53:29Z

Add property State in additional to ProvisioningState
We introduced State as suggested by ARM-Architect to provide more custom state outside of provisioning.

Currently value set for State would be same as ProvisioiningState until service side make further change.

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

azurecla · 2017-01-19T00:53:51Z

Hi @shihying, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (shic). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

azuresdkci · 2017-01-19T00:55:23Z

Can one of the admins verify this patch?

athipp

You might have to add a changelog file indicating the nature of the change in this version.
You also have to increment the minor version of the module in the app.config and AnalysisServices.psd1 file.

athipp · 2017-01-19T00:58:40Z

src/ResourceManager/AnalysisServices/Commands.AnalysisServices.Test/ScenarioTests/AsTests.ps1

@@ -95,13 +98,15 @@ function Test-AnalysisServicesServer
 		Suspend-AzureRmAnalysisServicesServer -ResourceGroupName $resourceGroupName -Name $serverName
 		[array]$serverGet = Get-AzureRmAnalysisServicesServer -ResourceGroupName $resourceGroupName -Name $serverName
 		$serverGetItem = $serverGet[0]
+		Assert-True {$serverGetItem.State -like "Paused"}


Add a comment saying that this is to ensure backward compatibility. The breaking server changes will be done after this is released.

shihying · 2017-01-19T01:40:58Z

@athipp
AS SDK module version bumped
Change log updated

shihying · 2017-01-19T01:53:23Z

power shell admin : please do not merge until SDK repo merge PR for this chagne

shihying · 2017-01-20T00:21:01Z

Ping, thx
+@markcowl
+@shahabhijeet

markcowl · 2017-01-24T01:44:55Z

@shihying you must publish your new library and update the nuget package reference for your cmdlets

shihying · 2017-01-24T09:28:09Z

@markcowl
Library 1.0.2-preview is published, package reference is updated already., thanks

markcowl · 2017-01-24T19:53:23Z

src/ResourceManager/AnalysisServices/ChangeLog.md

@@ -18,6 +18,8 @@
        - Additional information about change #1
 -->
 ## Current Release
+* Added State property in additional to ProvisioningState


You need to be more specific about this change. Which cmdlets will be affected, how would the user use the new State property. How is it different than Provinsioning State?

@markcowl , I have added more information about this change.
Currently ASPAAS service still return same for both State and ProvisioningState, we could not tell the user the actual different example until service side make change in future.

I already provided the difference in intention

shihying · 2017-01-30T13:18:56Z

@markcowl @shahabhijeet
Can you take a look on my updated ChangeLog.md? thanks

shahabhijeet · 2017-02-03T18:00:25Z

@azuresdkci add to whitelist

shihying · 2017-02-04T01:54:06Z

@shahabhijeet @markcowl ping....

cormacpayne · 2017-02-10T22:45:54Z

@markcowl @shahabhijeet ping

shahabhijeet · 2017-02-13T22:58:37Z

@shihying If the service is not ready with providing more info for the State property, is there a point in adding this property before the service enables it.
Also what is the time frame for the service team to enable this property from server side?
is it happening in 1 month... 6 months?

shihying · 2017-02-13T23:52:52Z

@shahabhijeet
The service side already provide this property in the response but the value would be same as ProvisioningState - I think we want to let the powershell to be compatible with latest service response :)

There is no exact plan yet - but I think it must happen in 1month..6months..thanks

markcowl · 2017-02-16T00:36:09Z

on demand run: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1395/

LGTM once the build passes

shihying added 10 commits January 18, 2017 13:38

first implementation of powershell

a38b513

Merge remote-tracking branch 'github/dev' into dev

89bfbcf

fix test

911b1f8

fix test

4b4f940

fix test

2237e75

fix test

749b0cf

move files

534a4c4

move files

a63677b

typo fix

8ac0726

move files

638f1e3

azurecla added the cla-not-required label Jan 19, 2017

athipp suggested changes Jan 19, 2017

View reviewed changes

increse module version in app.config

4f11e50

shihying added 2 commits January 23, 2017 21:03

Merge remote-tracking branch 'github/dev' into as-state

e86d375

typo in comment

6510e11

markcowl added the Changes Requested label Jan 24, 2017

markcowl requested changes Jan 24, 2017

View reviewed changes

add more description

06a370a

cormacpayne assigned markcowl and shahabhijeet Feb 10, 2017

markcowl approved these changes Feb 16, 2017

View reviewed changes

markcowl added Waiting for On Demand and removed Changes Requested labels Feb 16, 2017

cormacpayne merged commit 7c7ae6a into Azure:dev Feb 16, 2017

Add property State in additional to ProvisioningState #3406

Add property State in additional to ProvisioningState #3406

Uh oh!

Conversation

shihying commented Jan 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

azurecla commented Jan 19, 2017

Uh oh!

azuresdkci commented Jan 19, 2017

Uh oh!

athipp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shihying commented Jan 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shihying commented Jan 19, 2017

Uh oh!

shihying commented Jan 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markcowl commented Jan 24, 2017

Uh oh!

shihying commented Jan 24, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shihying commented Jan 30, 2017

Uh oh!

shahabhijeet commented Feb 3, 2017

Uh oh!

shihying commented Feb 4, 2017

Uh oh!

cormacpayne commented Feb 10, 2017

Uh oh!

shahabhijeet commented Feb 13, 2017

Uh oh!

shihying commented Feb 13, 2017

Uh oh!

markcowl commented Feb 16, 2017

Uh oh!

Uh oh!

shihying commented Jan 19, 2017 •

edited

Loading

shihying commented Jan 19, 2017 •

edited

Loading

shihying commented Jan 20, 2017 •

edited

Loading