Skip to content

ServiceBus Command Help files #3422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 3, 2017
Merged

ServiceBus Command Help files #3422

merged 6 commits into from
Feb 3, 2017

Conversation

v-Ajnava
Copy link

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

@v-Ajnava v-Ajnava requested a review from sazeesha January 25, 2017 22:50
@azurecla
Copy link

Hi @v-Ajnava, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (v-ajnava). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@cormacpayne
Copy link
Member

@v-Ajnava added Do Not Merge label since there are a few changes to be made. You can remove the label and ping me whenever you are ready to have this PR reviewed.

jtaubensee and others added 2 commits February 1, 2017 18:08
@jtaubensee
Copy link

@cormacpayne - @sethmanheim and I just updated this PR. Can you start reviewing?

@sethmanheim
Copy link
Member

@cormacpayne Hey Cormac, sorry for the nag. We'd love to get the help published for these cmdlets ASAP, since the module is already public. If you could review that'd be great.

@cormacpayne
Copy link
Member

cormacpayne commented Feb 2, 2017

@jtaubensee @sethmanheim Hey John and Seth, thanks for updating the documentation. For these changes to appear in the cmdlets, you will need to update Microsoft.Azure.Commands.ServiceBus.dll-Help.xml, which can be done by using the Update-ServiceMarkdownHelp cmdlet that we have in our platyPSHelp module.

Once that change is made, and the pull request is reviewed and merged, the changes will appear in the next release of Azure PowerShell on February 20th. Let me know if you guys have any other questions!

@sethmanheim
Copy link
Member

@jtaubensee I can do this if you show me how to pull this branch locally. It didn't work too well yesterday...

@cormacpayne
Copy link
Member

LGTM

@cormacpayne cormacpayne merged commit a2914d1 into Azure:dev Feb 3, 2017
@v-Ajnava v-Ajnava deleted the AJ_SBPower branch April 12, 2018 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants