Update to latest ADL Packages #3477

begoldsm · 2017-02-07T23:29:09Z

Description

Updates the following:

Switch to use the latest ADL package for Store. This includes the uploader and removes any portable constraints
Change the defaults for Import and Export to have a computed value that, in most cases, will give you the best performance, so no requirement to explicitly pass in thread counts.
Added Top functionality to Get-AdlJob to allow for returning a specific number of jobs through -Top

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

This includes a rework of the PowerShell friendly client and smart settings for file and folder upload/download. I also re-ran all tests to ensure that they are all still passing, which resulted in discovering that the MASK is now properly populated immediately when creating an account, so had to update the permissions tests.

Also remove test package.

Add warning to deletes. Fix from using private package Was using private package previously that hadn't fully refactored Upload -> Transfer Missed removal of Uploader package in tests. Fix the wxi file.

This is difficult to maintain and the RP itself should handle this when the attempt is sent. Unfortunately this has the by-product of removing tab completion from the cmdlet for locations, but maintaining this set when new regions are on boarded does not scale.

cormacpayne · 2017-02-14T22:21:49Z

@begoldsm ping for change log and package version update

cormacpayne

@begoldsm a few comments

LGTM once they have been resolved

cormacpayne · 2017-02-15T17:55:52Z

...rceManager/DataLakeAnalytics/Commands.DataLakeAnalytics.Test/ScenarioTests/AdlaAliasTests.cs

@@ -38,14 +38,24 @@ public void TestAdlaAccount()
        [Trait(Category.AcceptanceType, Category.CheckIn)]
        public void TestAdlaAccountTiers()
        {
-            AdlaTestsBase.NewInstance.RunPsTest(true,
+            AdlaTestsBase.NewInstance.RunPsTest(false,


@begoldsm out of curiosity, what does the boolean flip change, and is this something that needs to be changed throughout all RunPsTest calls in this class?

This was a fix to remove creation of a WASB storage account, since this test doesn't need it to be created, it was making recording runs of this test take longer. Only the TestAdlaAccount() test needs to create a WASB storage account.

cormacpayne · 2017-02-15T18:03:13Z

.../DataLakeAnalytics/Commands.DataLakeAnalytics/Commands/SetAzureRmDataLakeAnalyticsAccount.cs

@@ -63,8 +63,34 @@ public class SetAzureDataLakeAnalyticsAccount : DataLakeAnalyticsCmdletBase
        [ValidateNotNull]
        public TierType? Tier { get; set; }

+        [Parameter(ValueFromPipelineByPropertyName = true, Position = 4, Mandatory = false,


@begoldsm is this position attribute needed? If so, it looks like it should be 3 instead of 4

Good catch, and no, it does not need to be positional, I can remove it.

cormacpayne · 2017-02-15T18:07:29Z

...ataLakeAnalytics/Commands.DataLakeAnalytics/help/Add-AzureRmDataLakeAnalyticsFirewallRule.md

+# Add-AzureRmDataLakeAnalyticsFirewallRule
+
+## SYNOPSIS
+{{Fill in the Synopsis}}


@begoldsm it looks like the markdown files added for DataLakeAnalytics have a few sections that contain the templates from platyPS. Would you mind updating these and regenerating the dll-Help.xml file?

Will update right now.

azurecla added the cla-required label Feb 7, 2017

begoldsm added 4 commits February 8, 2017 12:20

Add support for returning a set number of jobs

1d22a14

Also remove test package.

Add warning for disabled IDP and firewall states

232be6f

Add warning to deletes. Fix from using private package Was using private package previously that hadn't fully refactored Upload -> Transfer Missed removal of Uploader package in tests. Fix the wxi file.

Update test recordings.

13f8f74

begoldsm force-pushed the dev branch from 9eea4f1 to 13f8f74 Compare February 8, 2017 20:21

begoldsm added 3 commits February 8, 2017 14:29

Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev

4988c05

Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev

3085d02

cormacpayne added cla-not-required and removed cla-required labels Feb 9, 2017

begoldsm added 3 commits February 10, 2017 10:02

Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev

6dd7b6e

Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev

8e079f8

Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev

ec45143

cormacpayne self-assigned this Feb 14, 2017

begoldsm added 4 commits February 14, 2017 15:17

Add Firewall Support, Rerun tests, update changelog

5e4c077

Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev

c59ea8b

Fixing code bug and broken tests.

d660109

Need to add json to csproj.

42fd0eb

cormacpayne suggested changes Feb 15, 2017

View reviewed changes

cormacpayne added the Changes Requested label Feb 15, 2017

Address PR comments about help

f4d8989

cormacpayne approved these changes Feb 15, 2017

View reviewed changes

cormacpayne merged commit acaa012 into Azure:dev Feb 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update to latest ADL Packages #3477

Update to latest ADL Packages #3477

Uh oh!

begoldsm commented Feb 7, 2017 •

edited

Loading

Uh oh!

cormacpayne commented Feb 14, 2017

Uh oh!

cormacpayne left a comment

Uh oh!

cormacpayne Feb 15, 2017

Uh oh!

begoldsm Feb 15, 2017

Uh oh!

cormacpayne Feb 15, 2017

Uh oh!

begoldsm Feb 15, 2017

Uh oh!

cormacpayne Feb 15, 2017

Uh oh!

begoldsm Feb 15, 2017

Uh oh!

Uh oh!

Update to latest ADL Packages #3477

Update to latest ADL Packages #3477

Uh oh!

Conversation

begoldsm commented Feb 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

cormacpayne commented Feb 14, 2017

Uh oh!

cormacpayne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

begoldsm commented Feb 7, 2017 •

edited

Loading