Skip to content

Event Hubs PowerShell: Generating Markdown files #3486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 10, 2017

Conversation

sethmanheim
Copy link
Member

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@azurecla
Copy link

azurecla commented Feb 9, 2017

Hi @sethmanheim, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (sethm). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@sethmanheim
Copy link
Member Author

Please don't merge yet; adding content to the Markdowns.

@sethmanheim sethmanheim changed the title Generating Markdown files Event Hubs PowerShell: Generating Markdown files Feb 9, 2017
@sethmanheim
Copy link
Member Author

Content added to markdowns, please review.

cc @jtaubensee @v-Ajnava @zeeshansayyed

@cormacpayne
Copy link
Member

@sethmanheim Hey Seth, it looks like BreakingChangeIssues.csv got included in your pull request somehow. Would you mind pulling the latest from dev and see if that gets rid of it?

@sethmanheim
Copy link
Member Author

@cormacpayne File removed -- looks good now, OK to merge.

@cormacpayne
Copy link
Member

LGTM

@sethmanheim thanks Seth!

@cormacpayne cormacpayne merged commit 2b7cd5b into Azure:dev Feb 10, 2017
@sethmanheim sethmanheim deleted the eh-ps branch February 10, 2017 22:09
@Pacort
Copy link

Pacort commented Feb 21, 2017

@sethmanheim @cormacpayne This change is breaking our build, error message from App Veyor: {"message":"Not Found","documentation_url":"https://developer.github.com/v3"} I believe there needs to be a "message", could you please fix it? Otherwise I might need to revert the commit in our PS documentation repo. Related question: Seth, did you on-boarded by yourself Evenhub or did Tara helped you? Thanks

@sethmanheim
Copy link
Member Author

@Pacort Yes I worked with Tara on this. I don't know how to fix the error -- sorry. Can you help?

@Pacort
Copy link

Pacort commented Feb 21, 2017

@sethmanheim Sorry, I meant a URL needs to be corrected. Thanks.

@Pacort
Copy link

Pacort commented Feb 21, 2017

Oh, I see. Ok. I will try to fix it. Looks like this URL https://developer.github.com/v3 is causing issues for some reason. I will try and if not I will escalate to VSC. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants