-
Notifications
You must be signed in to change notification settings - Fork 4k
Event Hubs PowerShell: Generating Markdown files #3486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @sethmanheim, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
Please don't merge yet; adding content to the Markdowns. |
Content added to markdowns, please review. |
@sethmanheim Hey Seth, it looks like |
@cormacpayne File removed -- looks good now, OK to merge. |
LGTM @sethmanheim thanks Seth! |
@sethmanheim @cormacpayne This change is breaking our build, error message from App Veyor: {"message":"Not Found","documentation_url":"https://developer.github.com/v3"} I believe there needs to be a "message", could you please fix it? Otherwise I might need to revert the commit in our PS documentation repo. Related question: Seth, did you on-boarded by yourself Evenhub or did Tara helped you? Thanks |
@Pacort Yes I worked with Tara on this. I don't know how to fix the error -- sorry. Can you help? |
@sethmanheim Sorry, I meant a URL needs to be corrected. Thanks. |
Oh, I see. Ok. I will try to fix it. Looks like this URL https://developer.github.com/v3 is causing issues for some reason. I will try and if not I will escalate to VSC. Thanks! |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines