Skip to content

Skip backup for Linux VMs when SkipVmBackup switch is specified #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 16, 2017
Merged

Skip backup for Linux VMs when SkipVmBackup switch is specified #3510

merged 19 commits into from
Feb 16, 2017

Conversation

krkhan
Copy link

@krkhan krkhan commented Feb 15, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Automated testing for ADE scenarios is blocked (fwded the thread). Manually verified the behavior.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@krkhan
Copy link
Author

krkhan commented Feb 15, 2017

On-demand run

Copy link
Contributor

@ejarvi ejarvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cormacpayne
Copy link
Member

@krkhan Hey Kamran, would you mind filling out the checklist provided above?

Also, it looks like there are no test coverage for this new functionality.

@shahabhijeet
Copy link
Contributor

@krkhan can you address the feedback about tests are not being added.
EOD today is code freeze.

@krkhan
Copy link
Author

krkhan commented Feb 16, 2017

@shahabhijeet Automated testing for Azure Disk Encryption scenarios is blocked, I forwarded you the internal thread. We tested this parameter's behavior manually.

@shahabhijeet shahabhijeet merged commit bcef6aa into Azure:dev Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants