-
Notifications
You must be signed in to change notification settings - Fork 4k
Skip backup for Linux VMs when SkipVmBackup switch is specified #3510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 2535c73.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@krkhan Hey Kamran, would you mind filling out the checklist provided above? Also, it looks like there are no test coverage for this new functionality. |
@krkhan can you address the feedback about tests are not being added. |
@shahabhijeet Automated testing for Azure Disk Encryption scenarios is blocked, I forwarded you the internal thread. We tested this parameter's behavior manually. |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Automated testing for ADE scenarios is blocked (fwded the thread). Manually verified the behavior.
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines