-
Notifications
You must be signed in to change notification settings - Fork 4k
Added cmdlets and tests for NetworkWatcher APIs #3516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @irrogozh, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! TTYL, AZPRBOT; |
@@ -33,61 +35,121 @@ EndProject | |||
Global | |||
GlobalSection(SolutionConfigurationPlatforms) = preSolution | |||
Debug|Any CPU = Debug|Any CPU | |||
Debug|x64 = Debug|x64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@irrogozh please remove all of the below references to x64 build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -65,6 +65,10 @@ | |||
<SpecificVersion>False</SpecificVersion> | |||
<HintPath>..\..\..\packages\Microsoft.Azure.Common.2.1.0\lib\net45\Microsoft.Azure.Common.NetFramework.dll</HintPath> | |||
</Reference> | |||
<Reference Include="Microsoft.Azure.Management.Network, Version=8.3.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@irrogozh please remove this reference to Network from ResourceManager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -5,6 +5,7 @@ | |||
<package id="Microsoft.AspNet.WebApi.Client" version="5.2.2" targetFramework="net45" /> | |||
<package id="Microsoft.Azure.Common" version="2.1.0" targetFramework="net45" /> | |||
<package id="Microsoft.Azure.Common.Dependencies" version="1.0.0" targetFramework="net45" /> | |||
<package id="Microsoft.Azure.Management.Network" version="8.3.0-preview" targetFramework="net45" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@irrogozh same comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@azuresdkci test this please |
On-demand build as passed: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1408/ Just restarted build for this PR since it was previously run on a different VM that was not configured LGTM once build passes |
Description
Fixes based on CR, resolved static analysis issues
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines