Update property name for get bgp service community cmdlets and remove name property for stats cmdlets #3572

dihan0604 · 2017-03-03T19:14:34Z

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

msftgits · 2017-03-03T19:49:17Z

Closing and reopening to try and ping the CLA bot.

msftgits · 2017-03-03T19:51:40Z

Trying again to bump CLA bot

dihan0604 · 2017-03-03T20:20:39Z

Fix issue: #3564

cormacpayne · 2017-03-03T21:33:29Z

src/ResourceManager/Network/Commands.Network.Test/packages.config

  <package id="Microsoft.Azure.Management.Compute" version="14.0.0-prerelease" targetFramework="net45" />
-  <package id="Microsoft.Azure.Management.Network" version="8.3.0-preview" targetFramework="net45" />
+  <package id="Microsoft.Azure.Management.Network" version="8.6.0-preview" targetFramework="net45" />


@dihan0604 the build is failing because this is not 9.0.0-preview

markcowl · 2017-03-03T23:26:32Z

@azuresdkci retest this please

markcowl · 2017-03-06T21:30:15Z

@dihan0604 Please update the PR title to be more descriptive, and please clean up the commits. We have some advice on cleaning up commits here: https://github.com/Azure/azure-powershell/blob/dev/documentation/cleaning-up-commits.md

markcowl · 2017-03-06T21:31:50Z

src/ResourceManager/Network/Commands.Network/Commands.Network.csproj

      <Private>True</Private>
    </Reference>
    <Reference Include="Microsoft.Rest.ClientRuntime.Azure, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.Azure.3.3.4\lib\net45\Microsoft.Rest.ClientRuntime.Azure.dll</HintPath>
+      <HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.Azure.3.3.5\lib\net45\Microsoft.Rest.ClientRuntime.Azure.dll</HintPath>


You are not going to be able to make this change without making this change across all RPs.

markcowl · 2017-03-06T21:32:06Z

src/ResourceManager/Network/Commands.Network/Commands.Network.csproj

@@ -98,11 +98,11 @@
      <Private>True</Private>
    </Reference>
    <Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.2.3.4\lib\net45\Microsoft.Rest.ClientRuntime.dll</HintPath>
+      <HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.2.3.5\lib\net45\Microsoft.Rest.ClientRuntime.dll</HintPath>


same for this reference

markcowl · 2017-03-06T21:33:40Z

...ork/Commands.Network/ExpressRouteCircuit/Stats/GetAzureExpressRouteCircuitARPTableCommand.cs

@@ -33,15 +33,7 @@ public enum DevicePathEnum

     [Cmdlet(VerbsCommon.Get, "AzureRmExpressRouteCircuitARPTable"),OutputType(typeof(PSExpressRouteCircuitArpTable))]
     public class GetAzureExpressRouteCircuitARPTableCommand : NetworkBaseCmdlet		
-     {		
-         [Alias("ResourceName")]		


You need to move this alias, and add an alias for Name to 'ExpressRouteCircuitName'. This applies to all of your cmdlet changes.

dihan0604 · 2017-03-06T22:37:51Z

@markcowl comments adressed.

markcowl · 2017-03-07T02:13:45Z

tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

Instead of this, add the alias 'Name' to each of the ExpressRouteCircuitName parameters.

markcowl · 2017-03-07T19:15:28Z

tools/StaticAnalysis/Exceptions/BreakingChangeIssues.csv

+"Microsoft.Azure.Commands.Compute.dll","Microsoft.Azure.Commands.Compute.Extension.Chef.SetAzureVMChefExtensionCommand","Set-AzureRmVMChefExtension","0","2090","The ValidateNotNullOrEmpty attribute has been added to parameter 'Windows' for cmdlet 'Set-AzureRmVMChefExtension'.","Remove the ValidateNotNullOrEmpty attribute from parameter 'Windows'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureExpressRouteCircuitARPTableCommand","Get-AzureRmExpressRouteCircuitARPTable","0","2030","The parameter 'Name' is no longer optional for the parameter set '__AllParameterSets' for cmdlet 'Get-AzureRmExpressRouteCircuitARPTable'.","Make 'Name' optional for the parameter set '__AllParameterSets'."
+"Microsoft.Azure.Commands.Network.dll","Microsoft.Azure.Commands.Network.GetAzureExpressRouteCircuitARPTableCommand","Get-AzureRmExpressRouteCircuitARPTable","0","2080","The parameter 'Name' in parameter set '__AllParameterSets' for cmdlet 'Get-AzureRmExpressRouteCircuitARPTable' no longer has the attribute 'ValueFromPipelineByPropertyName'.","Add the attribute 'ValueFromPipelineByPropertyName' back to parameter 'Name' in parameter set '__AllParameterSets'."


These exceptions around GetValueByPipelineByPropertyName still apply - ExpressRouteCircuitName shoudl allow getting its value from the pipeline by property name -> this allows piping in a Get from generic cmdlets into these methods.

The other exceptions are valid

dihan0604 · 2017-03-07T20:01:46Z

@markcowl Fixed the pipelinebypropertyname exception

…name property in stats cmdlets

markcowl · 2017-03-07T22:24:43Z

@azuresdkci retest this please

dihan0604 · 2017-03-08T00:34:06Z

On-demand passed: http://azuresdkci.cloudapp.net/job/powershell-demand/1429/

markcowl · 2017-03-08T18:43:18Z

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1435/

msftgits closed this Mar 3, 2017

msftgits reopened this Mar 3, 2017

msftgits closed this Mar 3, 2017

msftgits reopened this Mar 3, 2017

msftclas added the cla-not-required label Mar 3, 2017

cormacpayne reviewed Mar 3, 2017

View reviewed changes

cormacpayne added the Changes Requested label Mar 3, 2017

cormacpayne assigned markcowl and dihan0604 and unassigned markcowl Mar 3, 2017

cormacpayne assigned markcowl and unassigned dihan0604 Mar 6, 2017

dihan0604 force-pushed the dev branch from f34425a to 863c9f1 Compare March 6, 2017 21:33

markcowl requested changes Mar 6, 2017

View reviewed changes

dihan0604 force-pushed the dev branch from 66a1d75 to b898244 Compare March 6, 2017 22:37

dihan0604 changed the title ~~update property name~~ Update property name for get bgp service community cmdlets and remove name property for stats cmdlets Mar 6, 2017

markcowl requested changes Mar 7, 2017

View reviewed changes

markcowl assigned dihan0604 and unassigned markcowl Mar 7, 2017

markcowl requested changes Mar 7, 2017

View reviewed changes

Update property name in get bgp service community cmdlets and remove …

ded36fb

…name property in stats cmdlets

dihan0604 force-pushed the dev branch from 3547cca to ded36fb Compare March 7, 2017 22:23

markcowl changed the base branch from dev to release-3.7.0 March 8, 2017 00:23

Merge branch 'release-3.7.0' into dev

4c2ffc3

Merge branch 'release-3.7.0' into dev

e21093e

cormacpayne assigned markcowl and unassigned dihan0604 Mar 8, 2017

cormacpayne added needs-approval and removed Changes Requested labels Mar 8, 2017

markcowl approved these changes Mar 8, 2017

View reviewed changes

Merge branch 'release-3.7.0' into dev

5fe65c9

markcowl merged commit 8a1a6d5 into Azure:release-3.7.0 Mar 8, 2017

Update property name for get bgp service community cmdlets and remove name property for stats cmdlets #3572

Update property name for get bgp service community cmdlets and remove name property for stats cmdlets #3572

Uh oh!

Conversation

dihan0604 commented Mar 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

msftgits commented Mar 3, 2017

Uh oh!

msftgits commented Mar 3, 2017

Uh oh!

dihan0604 commented Mar 3, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl commented Mar 3, 2017

Uh oh!

markcowl commented Mar 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dihan0604 commented Mar 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dihan0604 commented Mar 7, 2017

Uh oh!

markcowl commented Mar 7, 2017

Uh oh!

dihan0604 commented Mar 8, 2017

Uh oh!

markcowl commented Mar 8, 2017

Uh oh!

Uh oh!

dihan0604 commented Mar 3, 2017 •

edited

Loading