Add ConnectionDraining to ApplicationGateway #3582

jobatzil · 2017-03-06T19:10:23Z

Description

Added the support of ConnectionDraining for ApplicationGateways.

Along the AGW specific changes, the Api-Version of the Network part has been changed to 2016-12-01 and thus the test recordings were updated accordingly.

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

…ation! (Tests only partial finished)

… the temporary fix of the INetworkInterface.ApiVersion

…o the project file.

…file.

…ing cmdlets (it is no resource).

…tionGateway compare function.

…nection_draining

…ls and test recordings for applicationgateway.

…6-09-01 to 2016-12-01.

…6-09-01 to 2016-12-01 in Compute part.

…nection_draining

…raining cmdlet.

…draining cmdlets.

…ng related operations. Updated application gateway cmdlets that were not up to date.

msftclas · 2017-03-06T19:10:27Z

@jobatzil,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

azuresdkci · 2017-03-06T19:15:09Z

Can one of the admins verify this patch?

cormacpayne · 2017-03-06T20:49:24Z

@azuresdkci add to whitelist

markcowl · 2017-03-06T21:23:26Z

@jobatzil You need to remove the app.config from your test project - this is why the build is failing

jobatzil · 2017-03-06T22:04:01Z

@markcowl Okay, removed all app.config added by me.

…eIssues.csv since all the changes are on local objects to prevent build from failing.

markcowl · 2017-03-07T02:20:31Z

...ApplicationGateway/ConnectionDraining/GetAzureApplicationGatewayConnectionDrainingCommand.cs

+namespace Microsoft.Azure.Commands.Network
+{
+    [Cmdlet(VerbsCommon.Get, "AzureRmApplicationGatewayConnectionDraining"),
+        OutputType(typeof(PSApplicationGatewayConnectionDraining))]


returns an array of these

It only returns one connection draining object.

I remove the true in write object.

markcowl · 2017-03-07T02:25:30Z

src/ResourceManager/Network/Commands.Network/packages.config

@@ -19,8 +19,8 @@
  <package id="Microsoft.Data.Services.Client" version="5.6.4" targetFramework="net45" />
  <package id="Microsoft.IdentityModel.Clients.ActiveDirectory" version="2.28.3" targetFramework="net45" />
  <package id="Microsoft.Net.Http" version="2.2.28" targetFramework="net45" />
-  <package id="Microsoft.Rest.ClientRuntime" version="2.3.4" targetFramework="net45" />
-  <package id="Microsoft.Rest.ClientRuntime.Azure" version="3.3.4" targetFramework="net45" />
+  <package id="Microsoft.Rest.ClientRuntime" version="2.3.5" targetFramework="net45" />


Unfortunately, this change needs to be made across the board, for all modules, changing in one module will just cause conflicts. WIlll discuss how to deal with this change in the mornign before cutting the new branch

…dlet for connection draining and WAF.

jobatzil added 27 commits February 15, 2017 16:13

#ConnectionDraining Check in of initial connection draining implement…

67f3e5d

…ation! (Tests only partial finished)

#ConnectionDraining Added the cmdlets to the network module and added…

841427f

… the temporary fix of the INetworkInterface.ApiVersion

#ConnectionDraining Added PSApplicationGatewayConenctionDraining.cs t…

f6b748e

…o the project file.

#ConnectionDraining Adding ConnectionDraining cmdlets to the project …

133ea03

…file.

#ConnectionDraining removed ShouldProcess support in connection drain…

f4bf268

…ing cmdlets (it is no resource).

#ConnectionDraining added comparison of connectiondraining in applica…

f01541a

…tionGateway compare function.

Merge remote-tracking branch 'upstream/dev' into feature/jobatzil/con…

859af68

…nection_draining

#ConnectionDraining Added connectiondraining to the mapper.

9ef966d

Merge remote-tracking branch 'upstream/dev' into feature/jobatzil/con…

9505e71

…nection_draining

#ConnectionDraining Added fix for 'Type unknown' error in restapi cal…

dc1ceb8

…ls and test recordings for applicationgateway.

Merge branch 'dev' into feature/jobatzil/connection_draining

8313b02

#ConnectionDraining Fixed agw tests.

50cb567

#ConnectionDraining Fixed double Type property in PSTopLevelResource.cs.

74c2051

#ConnectionDraining Fixed ApplicationGateway Test.

854843b

#ConnectionDraining Rewrote Recorded Network Headers from version 201…

833e812

…6-09-01 to 2016-12-01.

#ConnectionDraining Rewrote Recorded Network Headers from version 201…

10ccb52

…6-09-01 to 2016-12-01 in Compute part.

#ConnectionDraining Updated Network reference to newest package version.

a0d8037

Merge remote-tracking branch 'upstream/dev' into feature/jobatzil/con…

03ba247

…nection_draining

#ConnectionDraining Added ConnectionDrainingText to BackendHttpSettings.

1ea5c5a

#ConnectionDraining Added Remove-AzureRmApplicationGatewayConnectionD…

639b13e

…raining cmdlet.

#ConnectionDraining Improved ApplicationGateway tests.

acd21fd

#ConnectionDraining improved testing.

9448f09

#ConnectionDraining Added documentation files for the new connection …

4699da3

…draining cmdlets.

#ConnectionDraining Updated cmdlet documentation of connection draini…

2ee6032

…ng related operations. Updated application gateway cmdlets that were not up to date.

#ConnectionDraining Updated external XML help file.

52c7cd8

#ConnectionDraining Finalized agw Test.

b63c69d

#ConnectionDraining Filanlized PR.

f10cfd9

msftclas added the cla-not-required label Mar 6, 2017

#ConnectionDraining Removed app.config includings.

91f1fd1

jobatzil added 2 commits March 6, 2017 15:11

#ConnectionDraining updated Network/ChangeLog.md

086d521

#ConnectionDraining added new connection draining cmdlets to signatur…

81d5012

…eIssues.csv since all the changes are on local objects to prevent build from failing.

cormacpayne assigned markcowl Mar 7, 2017

markcowl requested changes Mar 7, 2017

View reviewed changes

markcowl assigned jobatzil and unassigned markcowl Mar 7, 2017

markcowl added the Changes Requested label Mar 7, 2017

#ConnectionDraining changed WriteObject Method that is used in get cm…

7a4f276

…dlet for connection draining and WAF.

markcowl approved these changes Mar 7, 2017

View reviewed changes

markcowl merged commit 5a342a6 into Azure:dev Mar 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add ConnectionDraining to ApplicationGateway #3582

Add ConnectionDraining to ApplicationGateway #3582

Uh oh!

jobatzil commented Mar 6, 2017

Uh oh!

msftclas commented Mar 6, 2017

Uh oh!

azuresdkci commented Mar 6, 2017

Uh oh!

cormacpayne commented Mar 6, 2017

Uh oh!

markcowl commented Mar 6, 2017

Uh oh!

jobatzil commented Mar 6, 2017

Uh oh!

markcowl Mar 7, 2017

Uh oh!

jobatzil Mar 7, 2017

Uh oh!

jobatzil Mar 7, 2017 •

edited

Loading

Uh oh!

markcowl Mar 7, 2017

Uh oh!

Uh oh!

Add ConnectionDraining to ApplicationGateway #3582

Add ConnectionDraining to ApplicationGateway #3582

Uh oh!

Conversation

jobatzil commented Mar 6, 2017

Description

General Guidelines

Testing Guidelines

Cmdlet Signature Guidelines

Cmdlet Parameter Guidelines

Uh oh!

msftclas commented Mar 6, 2017

Uh oh!

azuresdkci commented Mar 6, 2017

Uh oh!

cormacpayne commented Mar 6, 2017

Uh oh!

markcowl commented Mar 6, 2017

Uh oh!

jobatzil commented Mar 6, 2017

Uh oh!

markcowl Mar 7, 2017

Choose a reason for hiding this comment

Uh oh!

jobatzil Mar 7, 2017

Choose a reason for hiding this comment

Uh oh!

jobatzil Mar 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl Mar 7, 2017

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jobatzil Mar 7, 2017 •

edited

Loading