Updated external help for Microsoft.Compute #3624
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After submitting #3596 it was clear that the external help file had to be updated.
Contribution guidelines and this tweet confirm that New-ExternalHelp needs to be executed after we update cmdlets or the markdown files. However, the diff shows that there are significant changes were introduced after updating the external help.
This PR submits those changes for review.
More information
It looks like there are inconsistencies between markdown and external help for other services as well. For example, if i run New-ExternalHelp on the Websites module, aside from receiving a few errors caused by invalid markdown, the diff shows many differences again.
Should documentation PRs only be merged if they contain updated markdown and XML help?
Thanks guys!
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines