Remove-AzureRmAppServicePlan Help Example 1

[jonathanmedd]

Description

Help Example 1 for Remove-AzureRmAppServicePlan contains an incorrect parameter name for the name of the App Service Plan. If run as is, will generate the following error:

Remove-AzureRmAppServicePlan : A parameter cannot be found that matches parameter name 'AppServicePlanName'.

There are also inconsistencies between the markdown and XML files for the cmdlet Remove-AzureRmAppServicePlan, specifically:

1. The App Service Plan names do not match
2. The parameters AppServicePlanName and ResourceGroupName are in different orders

This PR changes the parameter AppServicePlanName to Name. It also resolves the above inconsistencies.

Additionally, I have changed the name of the App Service Plan from ContosoAppServPlan to ContosoASP to match the name in the recently merged PRs #3591 #3597 and #3605 so that someone following through the examples from New, Get, Set, Remove will see a consistent name of the plan to work with.

---

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

• I have read the contribution guidelines.
• If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
• If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
• The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

• Pull request includes test coverage for the included changes.
• PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

• New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
• Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

• Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
• Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
• Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

[msftclas]

@jonathanmedd,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

[cormacpayne]

@jonathanmedd thanks for another contribution, Jonathan!

LGTM