Add Common.Dependencies project #3734

cormacpayne · 2017-04-05T23:34:42Z

Description

Fix for issue #3435 and #3437

Add Common.Dependencies project, which will contain references to common libraries used throughout the modules.

Remove dependencies on cmdlet projects for ARM projects.

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

cormacpayne · 2017-04-14T20:57:19Z

@azuresdkci test this please

markcowl · 2017-04-21T00:59:12Z

src/Common/Commands.Common.Graph.RBAC/ActiveDirectory/ADObjectFilterOptions.cs

+// ----------------------------------------------------------------------------------
+
+
+namespace Microsoft.Azure.Graph.RBAC.ActiveDirectory


We should make the api version part of the namespace - this will make it easier to include a new version

markcowl · 2017-04-21T01:00:31Z

src/Common/Commands.Common.Graph.RBAC/Properties/AssemblyInfo.cs

+// set of attributes. Change these attribute values to modify the information
+// associated with an assembly.
+[assembly: AssemblyTitle("Commands.Common.GraphRBAC")]
+[assembly: AssemblyDescription("")]


We should fill these out

markcowl · 2017-04-21T01:03:01Z

src/Common/Commands.Common.Network/ILoadBalancers.cs

+// Changes may cause incorrect behavior and will be lost if the code is
+// regenerated.
+
+namespace Microsoft.Azure.Management.Internal.Network


Again, we should add the api-version to the namsepace

markcowl · 2017-04-21T01:04:31Z

src/Common/Common.Dependencies/Properties/AssemblyInfo.cs

+// set of attributes. Change these attribute values to modify the information
+// associated with an assembly.
+[assembly: AssemblyTitle("Common.Dependencies")]
+[assembly: AssemblyDescription("")]


We should fill out the details

markcowl · 2017-04-21T01:05:31Z

src/ResourceManager/AnalysisServices/Commands.AnalysisServices.Dataplane/packages.config

@@ -1,18 +1,3 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>


We can remove files with no depednencies.

markcowl · 2017-04-21T01:07:08Z

...ourceManager/Compute/Commands.Compute/RemoteDesktop/VirtualMachineRemoteDesktopBaseCmdlet.cs

@@ -12,7 +12,8 @@
 // limitations under the License.
 // ----------------------------------------------------------------------------------

-using Microsoft.Azure.Commands.Network;
+


remove extra space

cormacpayne · 2017-05-17T16:18:07Z

On-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1590/

markcowl · 2017-06-20T21:51:19Z

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1685/

…t.targets file, update BreakingChangeIssues.csv

…nto common-dependencies

…nto common-dependencies # Conflicts: # src/ResourceManager/Network/Commands.Network/Commands.Network.csproj # src/ResourceManager/Network/Commands.Network/packages.config

cormacpayne · 2017-07-27T23:38:40Z

On-demand: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1768/

Sign job: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/1217/

markcowl · 2017-07-27T23:43:32Z

src/Common/Commands.Common.Authorization/Properties/AssemblyInfo.cs

+// General Information about an assembly is controlled through the following 
+// set of attributes. Change these attribute values to modify the information
+// associated with an assembly.
+[assembly: AssemblyTitle("Commands.Common.Authorization")]


We should make these match the values in other common assemblies (particularly the copyright, company sruff). Liek this: https://github.com/Azure/azure-powershell/blob/preview/src/Common/Commands.Common.Authentication.Abstractions/Properties/AssemblyInfo.cs

markcowl · 2017-07-28T00:16:14Z

src/Common/Commands.Common.Network/packages.config

+  <package id="Microsoft.IdentityModel.Clients.ActiveDirectory" version="2.28.3" targetFramework="net452" />
+  <package id="Microsoft.Rest.ClientRuntime" version="2.3.5" targetFramework="net452" />
+  <package id="Microsoft.Rest.ClientRuntime.Azure" version="3.3.5" targetFramework="net452" />
+  <package id="Microsoft.Rest.ClientRuntime.Azure.Authentication" version="2.2.9-preview" targetFramework="net452" />


We should not need this

markcowl · 2017-07-28T00:17:13Z

src/Common/Commands.Common.Network/packages.config

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="Microsoft.IdentityModel.Clients.ActiveDirectory" version="2.28.3" targetFramework="net452" />


remove dependencies on ADAL and Azure.Authentication packages

markcowl · 2017-07-28T00:20:11Z

AzurePowershell.Test.targets

@@ -103,7 +104,7 @@
 			<XUnitTests Include=".\src\ResourceManager\Resources\Commands.Resources.Test\bin\Debug\Microsoft.Azure.Commands.Resources.Test.dll"/>
 			<XUnitTests Include=".\src\ResourceManager\Scheduler\Commands.Scheduler.Test\bin\Debug\Microsoft.Azure.Commands.Scheduler.Test.dll"/>
 			<!-- <XUnitTests Include=".\src\ResourceManager\ServerManagement\Commands.ServerManagement.Test\bin\Debug\Microsoft.Azure.Commands.ServerManagement.Test.dll"/> -->
-			<!-- <XUnitTests Include=".\src\ResourceManager\ServiceFabric\Commands.ServiceFabric.Test\bin\Debug\Microsoft.Azure.Commands.ServiceFabric.Test.dll"/> -->


let's leave this around so the service team can uncomment it.

@markcowl I removed this line because ServiceFabric already defined their test dll above (below KeyVault). I will move the uncommented line below ServiceBus

markcowl · 2017-07-28T00:22:58Z

setup/azurecmdfiles.wxi

                        <Component Id="cmpD85C4D043B5D7961FFDBBB38A14A782E" Guid="*">
                            <File Id="filBFB9D3DDC47B17AEBD9413E4DDDA77CC" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\Azure.AnalysisServices\Microsoft.IdentityModel.Clients.ActiveDirectory.dll" />
                        </Component>
                        <Component Id="cmpEAF41C675624E5CC949D2BC960518696" Guid="*">
                            <File Id="fil42FA267C2555527DAB21C3F75040CEA5" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\Azure.AnalysisServices\Microsoft.IdentityModel.Clients.ActiveDirectory.WindowsForms.dll" />
                        </Component>
+                        <Component Id="cmpDEED295F765F387FFB9382664C481366" Guid="*">
+                            <File Id="filFF02AF539455FC759869BFE97EEE1BE1" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\Azure.AnalysisServices\Microsoft.Rest.ClientRuntime.Azure.Authentication.dll" />


make sure to regen after the suggested changes

markcowl · 2017-07-28T00:26:37Z

tools/Common.Dependencies.targets

+      <HintPath>$(LibraryNugetPackageFolder)\Microsoft.Rest.ClientRuntime.Azure.3.3.5\lib\net45\Microsoft.Rest.ClientRuntime.Azure.dll</HintPath>
+      <Private>True</Private>
+    </Reference>
+    <Reference Include="Microsoft.Rest.ClientRuntime.Azure.Authentication">


remove azure.authentication, and two IdentityModel libraries - these should eb only in the authentication common libraires.

markcowl · 2017-07-28T00:28:22Z

tools/Common.Dependencies.targets

+    </Reference>
+    <Reference Include="System.Net.Http.WebRequest" />
+    <Reference Include="System.Runtime.Serialization" />
+    <Reference Include="System.Spatial">


System.Spatial is part of the Microsoft.WindowsAzure.Storage dependency chain. We cna move this out of here

…nto common-dependencies # Conflicts: # src/ResourceManager/AnalysisServices/Commands.AnalysisServices/Commands.AnalysisServices.csproj # src/ResourceManager/AnalysisServices/Commands.AnalysisServices/packages.config

cormacpayne · 2017-07-29T00:19:16Z

On-demand: http://azuresdkci.cloudapp.net/job/powershell-demand/1770/

Sign-job: http://azuresdkci.cloudapp.net/job/powershell-sign/1218/

markcowl · 2017-07-29T00:44:26Z

NuGet.config

    <add key="dotnet-core" value="https://dotnet.myget.org/F/dotnet-core/api/v3/index.json" />
    <add key="powershell-core" value="https://powershell.myget.org/F/powershell-core/api/v3/index.json" />
  </packageSources>
+  <disabledPackageSources>
+    <add key="local-feed" value="true" />


Please keep in local feed if possible

markcowl · 2017-07-31T17:16:51Z

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1779/

msftclas added the cla-not-required label Apr 5, 2017

azuresdkci assigned shahabhijeet Apr 5, 2017

shahabhijeet assigned markcowl and unassigned shahabhijeet Apr 10, 2017

markcowl assigned cormacpayne and unassigned markcowl Apr 13, 2017

markcowl added the Do Not Merge 🚫 label Apr 13, 2017

cormacpayne changed the title ~~[DO NOT MERGE] Add Common.Dependencies project~~ Add Common.Dependencies project Apr 14, 2017

cormacpayne added needs-review and removed Do Not Merge 🚫 labels Apr 14, 2017

cormacpayne assigned markcowl and unassigned cormacpayne Apr 14, 2017

cormacpayne force-pushed the common-dependencies branch 2 times, most recently from 5646803 to af2ccf9 Compare April 19, 2017 23:43

markcowl requested changes Apr 21, 2017

View reviewed changes

markcowl added needs-revision and removed needs-review labels Apr 21, 2017

markcowl assigned cormacpayne and unassigned markcowl Apr 21, 2017

markcowl mentioned this pull request Apr 21, 2017

Service Fabric RP PowerShell #3783

Merged

13 tasks

cormacpayne assigned markcowl and unassigned cormacpayne Apr 26, 2017

cormacpayne added needs-review Do Not Merge 🚫 and removed needs-revision needs-review labels Apr 26, 2017

azuresdkci added the needs-review label May 2, 2017

cormacpayne removed the Do Not Merge 🚫 label May 17, 2017

markcowl added needs-revision and removed needs-review labels Jun 13, 2017

cormacpayne added 7 commits July 25, 2017 10:00

Add generated code for Authorization library

6926b0d

Add generated code for Graph.RBAC library

4254cad

Add generated code for Network library

e8c0f1a

Add generated code for Gallery and Tags libraries

8268dcd

Update ARM and Storage projects with new references (except Resources)

4a128bc

Update Resources project with new references, re-record tests

dcf1326

Add Common.Dependencies.targets file, update wxi, minor update to Tes…

5c6864f

…t.targets file, update BreakingChangeIssues.csv

cormacpayne force-pushed the common-dependencies branch from a906a69 to 5c6864f Compare July 25, 2017 17:14

cormacpayne added 3 commits July 25, 2017 13:04

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

691caa1

…nto common-dependencies

Fix failures with Release configuration build

b116590

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

7010e3e

…nto common-dependencies # Conflicts: # src/ResourceManager/Network/Commands.Network/Commands.Network.csproj # src/ResourceManager/Network/Commands.Network/packages.config

markcowl requested changes Jul 28, 2017

View reviewed changes

cormacpayne added 2 commits July 28, 2017 13:54

Resolve review feedback

7768d25

markcowl reviewed Jul 29, 2017

View reviewed changes

markcowl previously approved these changes Jul 29, 2017

View reviewed changes

Revert change to NuGet.config

d42df90

cormacpayne dismissed markcowl’s stale review via d42df90 July 29, 2017 00:46

markcowl previously approved these changes Jul 30, 2017

View reviewed changes

Merge branch 'preview' into common-dependencies

6952dbd

cormacpayne dismissed markcowl’s stale review via 6952dbd July 31, 2017 16:33

markcowl approved these changes Jul 31, 2017

View reviewed changes

cormacpayne merged commit 9ee1941 into Azure:preview Jul 31, 2017

cormacpayne deleted the common-dependencies branch August 7, 2017 16:29

		// ----------------------------------------------------------------------------------


		namespace Microsoft.Azure.Graph.RBAC.ActiveDirectory

		@@ -1,18 +1,3 @@
		<?xml version="1.0" encoding="utf-8"?>
		<packages>

Add Common.Dependencies project #3734

Add Common.Dependencies project #3734

Uh oh!

Conversation

cormacpayne commented Apr 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

cormacpayne commented Apr 14, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented May 17, 2017

Uh oh!

markcowl commented Jun 20, 2017

Uh oh!

cormacpayne commented Jul 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented Jul 29, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl commented Jul 31, 2017

Uh oh!

Uh oh!

cormacpayne commented Apr 5, 2017 •

edited

Loading