Move ARM storage account management cmdlets to a new project. #377
Conversation
…nto XSCL44 Conflicts: src/ServiceManagement/Storage/Commands.Storage.Test/Service/MockStorageTableManagement.cs
|
Hi @EmmaZhu, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
| @@ -17,7 +17,7 @@ | |||
| using Microsoft.Azure.Management.Storage; | |||
| using System; | |||
|
|
|||
| namespace Microsoft.Azure.Commands.Compute | |||
| namespace Microsoft.Azure.Commands.Management.Storage | |||
There was a problem hiding this comment.
You mean other options for namespace? We decided to use this namespace after discussed with Mark and according to his suggestion..
There was a problem hiding this comment.
Yes, saw that. But what do you think of this namespace? It seems to me it's a bit confusing to put Commands and Management together, whereas the latter one usually means management library.
It seems to me the outlier is the Storage Data cmdlets, which shall be in a specialized namespace, not the Storage Management ones.
@markcowl Thoughts?
There was a problem hiding this comment.
@huangpf , can you reply in the mail thread I just forward to you? We can discuss and make a decision in the mail thread.
BTW, maybe next time you can raise your concern earlier before I sent the PR...:-)
There was a problem hiding this comment.
As you may know most of the time it's clearer to directly look at the code. :-)
|
LGTM, with some minor comments that are just for your information. Thanks. |
| @@ -0,0 +1,36 @@ | |||
| using System.Reflection; | |||
There was a problem hiding this comment.
Please add copyright headers to all cs files
|
@azuresdkci retest this please |
Move ARM storage account management cmdlets to a new project.
Move ARM storage account management cmdlets to a new project.