Azure Machine Learning WebServicesRP new API version #3796

NonStatic2014 · 2017-04-18T19:58:22Z

Description

Azure Machine Learning WebServicesRP new API version

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

cormacpayne

@NonStatic2014 a couple of comments

cormacpayne · 2017-04-19T23:56:20Z

.gitignore

@@ -203,3 +203,4 @@ FakesAssemblies/
 /tools/*.dll
 *.GhostDoc.xml
 pingme.txt
+tools/LocalFeed/


@NonStatic2014 why was this added?

Oops, temporary local change. should not be included. Will remove it.

cormacpayne · 2017-04-19T23:57:07Z

src/ResourceManager/MachineLearning/Commands.MachineLearning.Test/ScenarioTests/Common.ps1

@@ -54,21 +54,6 @@ Gets the default location for a provider
 #>
 function Get-ProviderLocation($providerNamespace, $resourceType)
 {
-    if ([Microsoft.Azure.Test.HttpRecorder.HttpMockServer]::Mode -ne `


@NonStatic2014 why are you no longer checking for provider location?

Trying to make the test execution predictable and not impacted by other cmdlet which not related to the test target.

cormacpayne · 2017-04-19T23:58:23Z

...ourceManager/MachineLearning/Commands.MachineLearning.Test/ScenarioTests/WebServiceTests.ps1

+
+			$newRegion = "westcentralus"
+
+			# Validate that service no longer exists 


@NonStatic2014 there seems to be a indentation issue with this file. Would you mind cleaning that up?

cormacpayne · 2017-04-20T01:08:15Z

src/ResourceManager/MachineLearning/AzureRM.MachineLearning.psd1

@@ -12,7 +12,7 @@
 # RootModule = ''

 # Version number of this module.
-ModuleVersion = '0.13.0'
+ModuleVersion = '1.0.0'


@NonStatic2014 do not bump this version, we will do that during the release process

cormacpayne · 2017-04-21T00:06:14Z

src/ResourceManager/MachineLearning/Commands.MachineLearning/Properties/AssemblyInfo.cs

-[assembly: AssemblyVersion("0.13.0")]
-[assembly: AssemblyFileVersion("0.13.0")]
+[assembly: AssemblyVersion("1.0.0")]
+[assembly: AssemblyFileVersion("1.0.0")]


@NonStatic2014 revert these changes as we will update these versions during the release process

cormacpayne · 2017-04-21T00:06:34Z

...hineLearning/Commands.MachineLearning/Microsoft.Azure.Commands.MachineLearning.dll-Help.psd1

@@ -9,7 +9,7 @@
 @{  

 # Version number of this module.  
-ModuleVersion = '0.9.0' 
+ModuleVersion = '1.0.0' 


@NonStatic2014 revert these changes as we will bump the version during the release process

cormacpayne · 2017-04-25T20:11:33Z

@NonStatic2014 Hey Klein, would you mind pulling the latest changes from the preview branch? These changes removed the dll-Help.xml files from the repository, so you will no longer need to update this file in your PR.

cormacpayne · 2017-04-27T19:50:51Z

@NonStatic2014 it looks like you are bringing in changes from older pull requests. You will need to rebase. You can do so by following the steps in this document: https://github.com/Azure/azure-powershell/blob/preview/documentation/cleaning-up-commits.md#rebasing

msftclas added the cla-not-required label Apr 18, 2017

azuresdkci assigned markcowl Apr 18, 2017

markcowl changed the base branch from dev to preview April 19, 2017 16:58

cormacpayne suggested changes Apr 21, 2017

View reviewed changes

cormacpayne assigned NonStatic2014 and unassigned markcowl Apr 21, 2017

cormacpayne added the needs-revision label Apr 21, 2017

NonStatic2014 closed this Apr 28, 2017

NonStatic2014 force-pushed the new_version branch from e3e1473 to 3440c4e Compare April 28, 2017 00:33

NonStatic2014 mentioned this pull request Apr 28, 2017

Azure Machine Learning WebServicesRP new API version (Re-submit) #3860

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Azure Machine Learning WebServicesRP new API version #3796

Azure Machine Learning WebServicesRP new API version #3796

Uh oh!

NonStatic2014 commented Apr 18, 2017 •

edited by azuresdkci

Loading

Uh oh!

cormacpayne left a comment

Uh oh!

cormacpayne Apr 19, 2017

Uh oh!

NonStatic2014 Apr 21, 2017

Uh oh!

cormacpayne Apr 19, 2017

Uh oh!

NonStatic2014 Apr 21, 2017

Uh oh!

cormacpayne Apr 19, 2017

Uh oh!

cormacpayne Apr 20, 2017

Uh oh!

cormacpayne Apr 21, 2017

Uh oh!

cormacpayne Apr 21, 2017

Uh oh!

cormacpayne commented Apr 25, 2017

Uh oh!

cormacpayne commented Apr 27, 2017

Uh oh!

Uh oh!


		$newRegion = "westcentralus"

		# Validate that service no longer exists

Azure Machine Learning WebServicesRP new API version #3796

Azure Machine Learning WebServicesRP new API version #3796

Uh oh!

Conversation

NonStatic2014 commented Apr 18, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

cormacpayne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented Apr 25, 2017

Uh oh!

cormacpayne commented Apr 27, 2017

Uh oh!

Uh oh!

NonStatic2014 commented Apr 18, 2017 •

edited by azuresdkci

Loading