Skip to content

Backup encryption settings and restore on failure #3824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed

Backup encryption settings and restore on failure #3824

wants to merge 23 commits into from

Conversation

krkhan
Copy link

@krkhan krkhan commented Apr 25, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

ADE testing for PS is not automated. The changes were tested manually.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

Copy link

@SudhakaraReddyEvuri-zz SudhakaraReddyEvuri-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test the changes with private MSI

@krkhan
Copy link
Author

krkhan commented Apr 25, 2017

Jenkins run

@cormacpayne
Copy link
Member

@krkhan Hey Kamran, would you mind doing a rebase so that you have a small number of commits? You can check out this document for information on rebasing: https://github.com/Azure/azure-powershell/blob/preview/documentation/cleaning-up-commits.md#rebasing

Also, would you mind adding a snippet to the change log describing the changes you have made in this pull request?

@cormacpayne cormacpayne assigned krkhan and unassigned cormacpayne Apr 26, 2017
@krkhan
Copy link
Author

krkhan commented Apr 27, 2017

Rebased and started new PR #3849

@krkhan krkhan closed this Apr 27, 2017
@krkhan krkhan deleted the backup_enc_settings branch April 27, 2017 18:09
cormacpayne added a commit that referenced this pull request Apr 27, 2017
Backup encryption settings and restore on failure (Supersedes #3824)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants