Skip to content

Improved tracing for sql tests. #3841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class AdvisorTests : SqlTestsBase
{
public AdvisorTests(ITestOutputHelper output)
public AdvisorTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

#region Server Advisor Tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,8 @@ protected override void SetupManagementClients(RestTestFramework.MockContext con
helper.SetupSomeOfManagementClients(sqlClient, sqlLegacyClient, storageClient, storageV2Client, resourcesClient, authorizationClient);
}

public AuditingTests(ITestOutputHelper output)
public AuditingTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,8 @@ protected override void SetupManagementClients(RestTestFramework.MockContext con
helper.SetupSomeOfManagementClients(sqlClient, sqlLegacyClient, storageClient, storageV2Client, resourcesClient, authorizationClient);
}

public DataMaskingTests(ITestOutputHelper output)
public DataMaskingTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class DatabaseActivationTests : SqlTestsBase
{
public DatabaseActivationTests(ITestOutputHelper output)
public DatabaseActivationTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,8 @@ protected override void SetupManagementClients(RestTestFramework.MockContext con
authorizationClient);
}

public DatabaseBackupStretchTests(ITestOutputHelper output)
public DatabaseBackupStretchTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class DatabaseBackupTests : SqlTestsBase
{
public DatabaseBackupTests(ITestOutputHelper output)
public DatabaseBackupTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,8 @@ protected override void SetupManagementClients(RestTestFramework.MockContext con
authorizationClient);
}

public DatabaseCrudStretchTests(ITestOutputHelper output)
public DatabaseCrudStretchTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class DatabaseReplicationTests : SqlTestsBase
{
public DatabaseReplicationTests(ITestOutputHelper output)
public DatabaseReplicationTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class ElasticPoolCrudTests : SqlTestsBase
{
public ElasticPoolCrudTests(ITestOutputHelper output)
public ElasticPoolCrudTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

// Currently the test runs too long to be marked as a check-in test.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class FailoverGroupTests : SqlTestsBase
{
public FailoverGroupTests(ITestOutputHelper output)
public FailoverGroupTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

// Currently the test runs too long to be marked as a check-in test.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class ImportExportTests : SqlTestsBase
{
public ImportExportTests(ITestOutputHelper output)
public ImportExportTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class IndexRecommendationTests : SqlTestsBase
{
public IndexRecommendationTests(ITestOutputHelper output)
public IndexRecommendationTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class LocationCapabilitiesTests : SqlTestsBase
{
public LocationCapabilitiesTests(ITestOutputHelper output)
public LocationCapabilitiesTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class ReadScaleCrudTests : SqlTestsBase
{
public ReadScaleCrudTests(ITestOutputHelper output)
public ReadScaleCrudTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class RecommendedActionTests : SqlTestsBase
{
public RecommendedActionTests(ITestOutputHelper output)
public RecommendedActionTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

#region Server Recommended Action Tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class RecommendedElasticPoolTests : SqlTestsBase
{
public RecommendedElasticPoolTests(ITestOutputHelper output)
public RecommendedElasticPoolTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class ServerActiveDirectoryAdministratorTest : SqlTestsBase
{
public ServerActiveDirectoryAdministratorTest(ITestOutputHelper output)
public ServerActiveDirectoryAdministratorTest(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact(Skip = "SQL team hould re-record this test.")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class ServerCommunicationLinkCrudTests : SqlTestsBase
{
public ServerCommunicationLinkCrudTests(ITestOutputHelper output)
public ServerCommunicationLinkCrudTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class ServerCrudTests : SqlTestsBase
{
public ServerCrudTests(ITestOutputHelper output)
public ServerCrudTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class ServerDisasterRecoveryConfigurationTests : SqlTestsBase
{
public ServerDisasterRecoveryConfigurationTests(ITestOutputHelper output)
public ServerDisasterRecoveryConfigurationTests(ITestOutputHelper output) : base(output)
{
var logger = new XunitTracingInterceptor(output);
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));

helper.TracingInterceptor = logger;
}

[Fact(Skip = "TODO fix the test failure")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class ServerKeyVaultKeyTests : SqlTestsBase
{
public ServerKeyVaultKeyTests(ITestOutputHelper output)
public ServerKeyVaultKeyTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class ServerUpgradeTests : SqlTestsBase
{
public ServerUpgradeTests(ITestOutputHelper output)
public ServerUpgradeTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class ServiceTierAdvisorTests : SqlTestsBase
{
public ServiceTierAdvisorTests(ITestOutputHelper output)
public ServiceTierAdvisorTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@ public class SqlTestsBase : RMTestBase

public string UserDomain { get; private set; }

protected SqlTestsBase()
{
helper = new SqlEvnSetupHelper();
}

protected SqlTestsBase(ITestOutputHelper output)
{
helper = new SqlEvnSetupHelper();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,8 @@ protected override void SetupManagementClients(RestTestFramework.MockContext con
authorizationClient);
}

public ThreatDetectionTests(ITestOutputHelper output)
public ThreatDetectionTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ namespace Microsoft.Azure.Commands.Sql.Test.ScenarioTests
{
public class TransparentDataEncryptionCrudTests : SqlTestsBase
{
public TransparentDataEncryptionCrudTests(ITestOutputHelper output)
public TransparentDataEncryptionCrudTests(ITestOutputHelper output) : base(output)
{
XunitTracingInterceptor.AddToContext(new XunitTracingInterceptor(output));
}

[Fact]
Expand Down