Skip to content

ADLA Catalog Updates and ADLS crash fix #3853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2017
Merged

Conversation

begoldsm
Copy link
Contributor

@begoldsm begoldsm commented Apr 27, 2017

Description

  • add support for ADLA catalog package get and list
  • Add support for listing the following catalog items from deeper ancestors:
    • Table
    • TVF
    • View
    • Statistics.
  • Fixed a bug that was causing powershell to crash sometimes during import of lots of small files to ADLS.

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

begoldsm added 3 commits April 24, 2017 18:26
This includes support for getting/listing packages as well as listing
tables, TVFs, statistics and views from higher levels of catalog item
paths as well as tests for these operations.
@@ -19,6 +19,7 @@
-->
## Current Release
* For `Import-AzureRMDataLakeStoreItem` and `Export-AzureRMDataLakeStoreItem` trace logging has been disabled by default to improve performance. If trace logging is desired please use the `-DiagnosticLogLevel` and `-DiagnosticLogPath` parameters
* Fixed a bug that would sometimes cause PowerShell to crash when uploading lots of small file to ADLS.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@begoldsm was this an issue that was stemming from the SDK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cormacpayne yes, and it was fixed in the SDK and an update was needed to the SDK package here. There was a null reference exception that was not being properly handled in the SDK that was getting thrown all the way out and ultimately causing PowerShell process to crash.

@cormacpayne
Copy link
Member

@markcowl markcowl merged commit 83e3c8c into Azure:preview Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants