ServiceBus : bug fix and New SDK Nuget version #3858

v-Ajnava · 2017-04-28T03:10:02Z

Description

Bug fix : some properties were not updated beacuse of the space inserted in swagger spec.
New SDK Nuget Version

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

…nto SBFixes # Conflicts: # src/ResourceManager/ServiceBus/Commands.ServiceBus/Commands.ServiceBus.csproj

cormacpayne

@v-Ajnava a couple of comments

Also, please make the same changes to the wxi file that I commented about in your other pull request

cormacpayne · 2017-04-28T21:45:56Z

src/ResourceManager/ServiceBus/ChangeLog.md

@@ -20,6 +20,8 @@
 -->
 ## Current Release

+* Bug fix : some properties were not updated beacuse of the space inserted in swagger spec. 


@v-Ajnava can you provide the types that this applies to?

updated change log with properties affected due to bug.

cormacpayne · 2017-04-28T21:52:12Z

src/ResourceManager/ServiceBus/Commands.ServiceBus/Cmdlets/Queue/SetAzureServiceBusQueue.cs


+            NamespaceAttributes getNamespaceLoc = Client.GetNamespace(ResourceGroup, NamespaceName);
+            QueueObj.Location = getNamespaceLoc.Location;


@v-Ajnava what if QueueObj is null?

checking for null object. if null object passed service will return error.

cormacpayne · 2017-04-28T21:53:33Z

src/ResourceManager/ServiceBus/Commands.ServiceBus/Models/QueueAttributes.cs

@@ -52,7 +52,6 @@ public QueueAttributes(QueueResource quResource)
                Status = quResource.Status;
                SupportOrdering = quResource.SupportOrdering;
                UpdatedAt = quResource.UpdatedAt;
-


@v-Ajnava please revert this change

cormacpayne · 2017-04-28T21:54:23Z

src/ResourceManager/ServiceBus/Commands.ServiceBus/Utilities/ServiceBusClient.cs

@@ -527,117 +497,6 @@ public bool DeleteSubscription(string resourceGroupName, string namespaceName, s
        }

        #endregion Subscription
-
-        //#region EventHub


@v-Ajnava why was all of this commented out? Nonetheless, it should be deleted instead of commented out

Deleted all commented code.

…nto SBFixes

markcowl

Will file an issue for the changelog update

markcowl · 2017-05-01T00:39:06Z

src/ResourceManager/ServiceBus/ChangeLog.md

@@ -20,6 +20,9 @@
 -->
 ## Current Release

+* Bug fix : some properties of Queue object were not updated beacuse of the space inserted in there name in swagger spec. 


Thin k of this form the customer perspective - what would the customer need to know about this - just what the affects of the bug were and that it was fixed, not the root cause.

Verified changes in Cormac review

markcowl · 2017-05-01T00:44:33Z

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1503/

Issue to fix changelog is here: #3872

Ajit Navasare (MINDTREE LIMITED) added 7 commits April 7, 2017 18:14

ServiceBus fixes

ae419ba

New nuget

e4f3a5f

updated with markdown help changes

4ed9d8b

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

8d0e38b

…nto SBFixes # Conflicts: # src/ResourceManager/ServiceBus/Commands.ServiceBus/Commands.ServiceBus.csproj

update wxi

193ec68

removed commented code

70cfe92

updated session records

438e1a1

msftclas added the cla-required label Apr 28, 2017

azuresdkci assigned cormacpayne Apr 28, 2017

cormacpayne added cla-not-required and removed cla-required labels Apr 28, 2017

Import tag location changed

232089a

cormacpayne previously requested changes Apr 28, 2017

View reviewed changes

cormacpayne added needs-revision and removed needs-review labels Apr 28, 2017

cormacpayne assigned v-Ajnava and unassigned cormacpayne Apr 28, 2017

Ajit Navasare (MINDTREE LIMITED) added 3 commits April 28, 2017 15:35

updated review comments

f32e396

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

747992b

…nto SBFixes

updated wxi

94c17a5

v-Ajnava added needs-review and removed needs-revision labels Apr 29, 2017

v-Ajnava assigned cormacpayne Apr 29, 2017

markcowl approved these changes May 1, 2017

View reviewed changes

markcowl added Waiting for On Demand and removed needs-review labels May 1, 2017

markcowl merged commit bc518f2 into Azure:preview May 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ServiceBus : bug fix and New SDK Nuget version #3858

ServiceBus : bug fix and New SDK Nuget version #3858

Uh oh!

v-Ajnava commented Apr 28, 2017 •

edited by azuresdkci

Loading

Uh oh!

cormacpayne left a comment

Uh oh!

cormacpayne Apr 28, 2017

Uh oh!

v-Ajnava Apr 29, 2017

Uh oh!

cormacpayne Apr 28, 2017

Uh oh!

v-Ajnava Apr 29, 2017

Uh oh!

cormacpayne Apr 28, 2017

Uh oh!

v-Ajnava Apr 29, 2017

Uh oh!

cormacpayne Apr 28, 2017

Uh oh!

v-Ajnava Apr 29, 2017

Uh oh!

markcowl left a comment

Uh oh!

markcowl May 1, 2017

Uh oh!

markcowl commented May 1, 2017

Uh oh!

Uh oh!


		NamespaceAttributes getNamespaceLoc = Client.GetNamespace(ResourceGroup, NamespaceName);
		QueueObj.Location = getNamespaceLoc.Location;

ServiceBus : bug fix and New SDK Nuget version #3858

ServiceBus : bug fix and New SDK Nuget version #3858

Uh oh!

Conversation

v-Ajnava commented Apr 28, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

cormacpayne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl commented May 1, 2017

Uh oh!

Uh oh!

v-Ajnava commented Apr 28, 2017 •

edited by azuresdkci

Loading