-
Notifications
You must be signed in to change notification settings - Fork 4k
update getobjectbyobjectid api version to 1.6 from 1.6-internal #3859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@cormacpayne the build is failing due to some change unrelated to my code.Does this block the merging of my Pull request? |
@darshanhs90 please assign back to me and add the |
@cormacpayne updated the dependencies and assigned back to you with the needs-review label |
@darshanhs90 Tere are merge conflicts, please pull the latest from the preview branch and update. Are you adding any dependencies with new filenames? If not, you do not need to update the wxi file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darshanhs90 You don't need to update the wxi file if you are only changing dependency assembly versions, you only need to change it if you are adding new depedency files.
Need to pull in the latest to fix merge conflicts. Running an on-demand job to see if there are any early issues with the change
on demand run (just to check issues) here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1505/ |
@markcowl the changes done are part of the dependencies where the earlier projects used reference like net45/graph.rbac.dll but the new one uses reference like net452/graph.rbac.dll. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not need to update the wxi at all for this change. Please checkout the version upstream and resubmit. The changes to the wxi will not work
@markcowl when i remove the wxi file and revert to the upstream version,I am getting build issues as per this log http://azuresdkci.cloudapp.net/job/powershell/8455/console |
setup/azurecmdfiles.wxi
Outdated
@@ -7554,4 +7554,4 @@ | |||
<ComponentRef Id="cmpE6E248F4029BF7DACCD9C87C2D38BD38" /> | |||
</ComponentGroup> | |||
</Fragment> | |||
</Include> | |||
</Include> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert any change here - this is likely causing your build issues. Please check out the latest version of the wxi file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl checked out the wxi file ,got the build error again
@azuresdkci test this please |
@darshanhs90 inside your powershell clone, run this command:
This will checkout the version of the wxi file in the preview branch. Then push to your branch. There should be no change to the wxi file in your PR. Please ensure that your PR does not show any change to the wxi file. |
@markcowl updated the wxi file using the command mentioned by you |
@darshanhs90 This is still failing, it looks like your local clone may not have been up to date when you did this, please try git fetch upstream and repeat the command above. If not, I will recreate a new PR for you with these changes tomorrow. |
@darshanhs90 We opened this PR: #3892 which has the same changes as this one. Closing in favor of the new PR |
Update Graph RBAc client to version 1.6 for authorization cmdlets (#3859)
This pr is as part of the following bug fix
#3407
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines