Skip to content

update getobjectbyobjectid api version to 1.6 from 1.6-internal #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from

Conversation

darshanhs90
Copy link
Contributor

@darshanhs90 darshanhs90 commented Apr 28, 2017

This pr is as part of the following bug fix
#3407

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@darshanhs90
Copy link
Contributor Author

@cormacpayne the build is failing due to some change unrelated to my code.Does this block the merging of my Pull request?

@cormacpayne
Copy link
Member

@darshanhs90 please assign back to me and add the needs-review label when changes to other projects (updating to 4.5.2) are pushed

@darshanhs90
Copy link
Contributor Author

@cormacpayne updated the dependencies and assigned back to you with the needs-review label

@markcowl
Copy link
Member

@darshanhs90 Tere are merge conflicts, please pull the latest from the preview branch and update. Are you adding any dependencies with new filenames? If not, you do not need to update the wxi file.

Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darshanhs90 You don't need to update the wxi file if you are only changing dependency assembly versions, you only need to change it if you are adding new depedency files.

Need to pull in the latest to fix merge conflicts. Running an on-demand job to see if there are any early issues with the change

@markcowl
Copy link
Member

markcowl commented May 1, 2017

on demand run (just to check issues) here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1505/

@darshanhs90
Copy link
Contributor Author

@markcowl the changes done are part of the dependencies where the earlier projects used reference like net45/graph.rbac.dll but the new one uses reference like net452/graph.rbac.dll.
Since this resulted in an build error due to wxi file not being updated.
As per the advice from @cormacpayne I had to regenerate the wxi file and include that also

markcowl
markcowl previously approved these changes May 1, 2017
Copy link
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not need to update the wxi at all for this change. Please checkout the version upstream and resubmit. The changes to the wxi will not work

@darshanhs90
Copy link
Contributor Author

@markcowl when i remove the wxi file and revert to the upstream version,I am getting build issues as per this log http://azuresdkci.cloudapp.net/job/powershell/8455/console
Is there something that i am missing which is causing this issue in the build?

@@ -7554,4 +7554,4 @@
<ComponentRef Id="cmpE6E248F4029BF7DACCD9C87C2D38BD38" />
</ComponentGroup>
</Fragment>
</Include>
</Include>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert any change here - this is likely causing your build issues. Please check out the latest version of the wxi file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markcowl checked out the wxi file ,got the build error again

@cormacpayne
Copy link
Member

@azuresdkci test this please

@cormacpayne
Copy link
Member

@markcowl
Copy link
Member

markcowl commented May 2, 2017

@darshanhs90 inside your powershell clone, run this command:

git checkout -f upstream/preview -- setup/azurecmdfiles.wxi

This will checkout the version of the wxi file in the preview branch. Then push to your branch. There should be no change to the wxi file in your PR. Please ensure that your PR does not show any change to the wxi file.

@darshanhs90
Copy link
Contributor Author

@markcowl updated the wxi file using the command mentioned by you

@cormacpayne
Copy link
Member

cormacpayne commented May 3, 2017

@markcowl
Copy link
Member

markcowl commented May 3, 2017

@darshanhs90 This is still failing, it looks like your local clone may not have been up to date when you did this, please try git fetch upstream and repeat the command above.

If not, I will recreate a new PR for you with these changes tomorrow.

@markcowl
Copy link
Member

markcowl commented May 3, 2017

@darshanhs90 We opened this PR: #3892 which has the same changes as this one. Closing in favor of the new PR

@markcowl markcowl closed this May 3, 2017
markcowl added a commit that referenced this pull request May 3, 2017
Update Graph RBAc client to version 1.6 for authorization cmdlets (#3859)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants