Skip to content

Fix new-AzureStorageContext in new PSH window failure #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

blueww
Copy link
Member

@blueww blueww commented May 9, 2017

Fix the following issue:
After install the msi, and open a PowerShell window, create storage context will fail.

After debug, it seems caused by: In a new PSH window, get DefaultContext will get InvalidOperationException instead of return null.
• If import module, the SMProfile.DefaultContext will not be null, so get DefaultContext will success. So the issue not repro.
• If install msi and open window, SMProfile will be null so get DefaultContext will get exception. So the issue repro.


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • [Y ] Title of the pull request is clear and informative.
  • [Y ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • [Y ] The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • [Y ] Pull request includes test coverage for the included changes.
  • [Y ] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • [Y ] New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • [Y ] Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • [ Y] Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • [Y ] Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • [Y ] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

@markcowl
Copy link
Member

markcowl commented May 9, 2017

@blueww Not sure where this fix comes from, but it is too late for this release. Closing for now, can reopen after BUILD release.

@markcowl
Copy link
Member

markcowl commented May 9, 2017

@blueww I have reproed the issue. I don't think this is the right fix for this issue. If it's important enough, we can discuss a hotfix for after the release goes out, but it is too late to make the release train at this point.

@blueww
Copy link
Member Author

blueww commented May 10, 2017

@markcowl
This bug is very severe, I believe many customer will meet it as there are many script has New-AzureStorageContext at the begin. (For dataplan blob/file manage)

We should fix it in May release. Please help on that.
Thanks!

@markcowl
Copy link
Member

Closing in favor of #3938

@markcowl markcowl closed this May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants