-
Notifications
You must be signed in to change notification settings - Fork 4k
Switch to swagger generated SDK for operational insights powershell commands #3961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@shahabhijeet Fixed the build error from last week and Haitao also signed off. Could you take a look now? There was minimal functional change. The main change is just switching to operational insight SDK 0.18 which is based on swagger now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change and need to pass the on demand run, other wise LGTM
public string Sku { get; set; } | ||
|
||
[Parameter(Position = 4, Mandatory = false, ValueFromPipelineByPropertyName = true, | ||
HelpMessage = "The resource tags for the workspace.")] | ||
public Hashtable Tags { get; set; } | ||
|
||
[Parameter(Position = 5, Mandatory = false, ValueFromPipelineByPropertyName = true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the position property from this parameter. > 4 positional parameters is too many.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl , fixed by removing the position parameter.
@markcowl , @shahabhijeet , I addressed the comments. Please take a look and sign off if no other issues. Thank you very much! |
on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1594/ LGTM once this passes |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines