Updating getobjectsbyobjectId call for objectIds > 1000 #4002

darshanhs90 · 2017-05-19T01:02:30Z

Description

Updating getobjectsbyobjectId call for objectIds > 1000,since they API limits only 1000 objectIds

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

…nto preview

wisexp · 2017-05-19T01:11:35Z

...ResourceManager/Resources/Commands.Resources/Models.ActiveDirectory/ActiveDirectoryClient.cs

+            for(int i=0; i<objectIds.Count; i+=1000)
+            {
+                if((i+1000) > objectIds.Count){
+                    adObjects = GraphClient.Objects.GetObjectsByObjectIds(new GetObjectsParameters { ObjectIds = objectIds.GetRange(i, objectIds.Count - i), IncludeDirectoryObjectReferences = true });


objectIds.Count - i [](start = 135, length = 19)

compute the end index in "if-else" block then merge two graph calls into one line #Resolved

wisexp · 2017-05-19T01:12:03Z

...ResourceManager/Resources/Commands.Resources/Models.ActiveDirectory/ActiveDirectoryClient.cs

-            var adObjects = GraphClient.Objects.GetObjectsByObjectIds(new GetObjectsParameters { ObjectIds = objectIds, IncludeDirectoryObjectReferences = true });
-            result.AddRange(adObjects.Select(o => o.ToPSADObject()));
+            IPage<AADObject> adObjects;
+            for(int i=0; i<objectIds.Count; i+=1000)


1000 [](start = 47, length = 4)

it will be better to write a comment that graph only supports up to 1000 ids. #Resolved

wisexp · 2017-05-19T01:12:41Z

...ommands.Resources.Test.ScenarioTests.ResourceGroupTests/TestGetNonExistingResourceGroup.json

+          "FxVersion/4.7.2046.0",
+          "OSName/Windows_10_Enterprise",
+          "OSVersion/6.3.15063",
+          "Microsoft.Azure.Management.ResourceManager.ResourceManagementClient/1.6.0-preview"


entClient/1.6.0-preview [](start = 69, length = 23)

are these stuff related to your change? #Resolved

I just ran the other test cases to make sure they still work in record mode since the session records had become stale( as the test cases were ran almost a year back)

In reply to: 117386585 [](ancestors = 117386585)

I think it's better to update them in a separate PR for tracking purpose.

In reply to: 117542183 [](ancestors = 117542183,117386585)

reverted the extra ones

In reply to: 117567000 [](ancestors = 117567000,117542183,117386585)

wisexp · 2017-05-19T22:43:59Z

darshanhs90 · 2017-05-23T18:05:36Z

@shahabhijeet Is there anything blocking from my side for the pr to be merged?

markcowl

This looks food. Please add a description of this change (what behavior was changed from a customer perspective) to the changelog for the resource manager cmdlets

markcowl · 2017-05-24T00:46:21Z

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1605/

signing run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/1066/

LGTM once these pass

darshanhs90 · 2017-05-25T00:46:05Z

@markcowl The signing run is failing for 'Stop-AzureStorageBlobCopy' return type 'AzureStorageBlob'."
ERROR - System.InvalidOperationException: One or more errors occurred in validation. See the analysis repots at D:\workspace\powershell-sign\src\Package for details at StaticAnalysis.AnalysisLogger.CheckForIssues(Int32 maxSeverity) in D:\workspace\powershell-sign\tools\StaticAnalysis\Loggers\AnalysisLogger.cs:line 185

do let me know no what can be done to get this PR merged

markcowl · 2017-05-25T21:52:35Z

@darshanhs90 This is failing due to reports of breaking change issues. Most likely this means you are not up to date with the preview branch. Please pull the latest from the preview branch and push to your fork.

…nto preview

darshanhs90 · 2017-05-26T00:11:30Z

@markcowl updated the code with the latest code from the upstream

markcowl · 2017-05-26T01:47:38Z

new on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1612/

new signing run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/1082/

darshanhs90 · 2017-05-26T17:56:20Z

the ondemand run passed,however the signing run failed again even after i restarted it
http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-sign/1083/

…nto preview

darshanhs90 added 2 commits May 18, 2017 17:35

getobjects call updated for objects more than 1000

72f023f

Merge branch 'preview' of https://github.com/azure/azure-powershell i…

86e48c8

…nto preview

msftclas added the cla-not-required label May 19, 2017

wisexp reviewed May 19, 2017

View reviewed changes

azuresdkci added the needs-review label May 19, 2017

azuresdkci assigned shahabhijeet May 19, 2017

darshanhs90 added 3 commits May 19, 2017 11:13

resolve comments

a215dcb

reverting session records to fix cred scanner build error

e46cc1e

rever other session records

21a7978

darshanhs90 requested a review from shahabhijeet May 19, 2017 22:53

markcowl requested changes May 23, 2017

View reviewed changes

markcowl added needs-revision and removed needs-review labels May 23, 2017

updated the changelog

637c162

darshanhs90 added needs-review and removed needs-revision labels May 23, 2017

markcowl approved these changes May 24, 2017

View reviewed changes

markcowl removed the request for review from shahabhijeet May 24, 2017 00:39

markcowl added Waiting for On Demand and removed needs-review labels May 24, 2017

markcowl added needs-revision and removed Waiting for On Demand labels May 25, 2017

Merge branch 'preview' of https://github.com/azure/azure-powershell i…

c989691

…nto preview

Merge branch 'preview' of https://github.com/azure/azure-powershell i…

b7f56f7

…nto preview

markcowl merged commit 47eb780 into Azure:preview May 30, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updating getobjectsbyobjectId call for objectIds > 1000 #4002

Updating getobjectsbyobjectId call for objectIds > 1000 #4002

Uh oh!

darshanhs90 commented May 19, 2017 •

edited by azuresdkci

Loading

Uh oh!

wisexp May 19, 2017 •

edited by darshanhs90

Loading

Uh oh!

wisexp May 19, 2017 •

edited by darshanhs90

Loading

Uh oh!

wisexp May 19, 2017 •

edited by darshanhs90

Loading

Uh oh!

darshanhs90 May 19, 2017

Uh oh!

wisexp May 19, 2017

Uh oh!

darshanhs90 May 19, 2017

Uh oh!

wisexp commented May 19, 2017

Uh oh!

darshanhs90 commented May 23, 2017

Uh oh!

markcowl left a comment

Uh oh!

markcowl commented May 24, 2017

Uh oh!

darshanhs90 commented May 25, 2017

Uh oh!

markcowl commented May 25, 2017

Uh oh!

darshanhs90 commented May 26, 2017

Uh oh!

markcowl commented May 26, 2017

Uh oh!

darshanhs90 commented May 26, 2017

Uh oh!

Uh oh!

Updating getobjectsbyobjectId call for objectIds > 1000 #4002

Updating getobjectsbyobjectId call for objectIds > 1000 #4002

Uh oh!

Conversation

darshanhs90 commented May 19, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

General Guidelines

Testing Guidelines

Cmdlet Signature Guidelines

Cmdlet Parameter Guidelines

Uh oh!

wisexp May 19, 2017 • edited by darshanhs90 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wisexp May 19, 2017 • edited by darshanhs90 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wisexp May 19, 2017 • edited by darshanhs90 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

darshanhs90 May 19, 2017

Choose a reason for hiding this comment

Uh oh!

wisexp May 19, 2017

Choose a reason for hiding this comment

Uh oh!

darshanhs90 May 19, 2017

Choose a reason for hiding this comment

Uh oh!

wisexp commented May 19, 2017

Uh oh!

darshanhs90 commented May 23, 2017

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

markcowl commented May 24, 2017

Uh oh!

darshanhs90 commented May 25, 2017

Uh oh!

markcowl commented May 25, 2017

Uh oh!

darshanhs90 commented May 26, 2017

Uh oh!

markcowl commented May 26, 2017

Uh oh!

darshanhs90 commented May 26, 2017

Uh oh!

Uh oh!

darshanhs90 commented May 19, 2017 •

edited by azuresdkci

Loading

wisexp May 19, 2017 •

edited by darshanhs90

Loading

wisexp May 19, 2017 •

edited by darshanhs90

Loading

wisexp May 19, 2017 •

edited by darshanhs90

Loading