Implemeted Usage cmdlet for Network; Added usage tests #4009

EvgenyAgafonchikov · 2017-05-22T14:15:33Z

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

msftclas · 2017-05-22T14:15:37Z

@EvgenyAgafonchikov,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

azuresdkci · 2017-05-22T14:20:07Z

Can one of the admins verify this patch?

EvgenyAgafonchikov · 2017-05-23T14:30:02Z

@markcowl could you please clarify is this part required now:

If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.

It looks like there is no XML help file in Network module now. Was something moved/restructured?

markcowl · 2017-05-24T00:37:44Z

@EvgenyAgafonchikov Help is now all in markdown - the xml file is created at runtime. See: https://github.com/Azure/azure-powershell/blob/preview/documentation/help-generation.md

markcowl · 2017-05-26T02:07:48Z

src/ResourceManager/Network/Commands.Network/help/Get-AzureRmNetworkUsage.md

+# Get-AzureRmNetworkUsage
+
+## SYNOPSIS
+{{Fill in the Synopsis}}


You have to actually fill these in with proper values

markcowl · 2017-05-26T02:09:34Z

src/ResourceManager/Network/Commands.Network/Usage/GetAzureNetworkUsageCommand.cs

+namespace Microsoft.Azure.Commands.Network.Automation
+{
+    [Cmdlet(VerbsCommon.Get, "AzureRmNetworkUsage")]
+    public partial class GetAzureRmNetworkUsage : NetworkBaseCmdlet


Need an OutputType attribute, with the proper OutputType

markcowl · 2017-05-26T02:11:48Z

@DeepakRajendranMsft can you please review/approve?

markcowl · 2017-05-30T18:48:43Z

src/ResourceManager/Network/Commands.Network/help/Get-AzureRmNetworkUsage.md

+PS C:\> Get-AzureRmNetworkUsage -Location westcentralus
+```
+
+Gets resources usage data in westcentralus region


Please show a representation of the output of the cmdlet

markcowl · 2017-05-30T18:50:08Z

src/ResourceManager/Network/Commands.Network/Usage/GetAzureNetworkUsageCommand.cs

+
+namespace Microsoft.Azure.Commands.Network.Automation
+{
+    [Cmdlet(VerbsCommon.Get, "AzureRmNetworkUsage"), OutputType(typeof(PSUsage))]


What does the output of this cmdlet look like on screen? Please see the help comments below and include this. You will want to make sure that the most relevant information is displayed, and extraneous information is not.

@markcowl, I've updated documentation. Could you please have a look?

DeepakRajendranMsft · 2017-05-30T22:04:43Z

@markcowl @EvgenyAgafonchikov i have approved the changes

markcowl · 2017-06-04T00:05:26Z

src/ResourceManager/Network/Commands.Network/Microsoft.Azure.Commands.Network.format.ps1xml

+      <ViewSelectedBy>
+        <TypeName>Microsoft.Azure.Commands.Network.Models.PSUsage</TypeName>
+      </ViewSelectedBy>
+      <ListControl>


The ddefault here should be a table view - with only 3 columns, this makes the display much easier. Users can always use the list view by piping through fl

markcowl · 2017-06-04T00:07:01Z

@azuresdkci add to whitelist

markcowl · 2017-06-04T00:08:45Z

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1643/

msftclas added the cla-already-signed label May 22, 2017

azuresdkci added the needs-review label May 22, 2017

EvgenyAgafonchikov force-pushed the networkusage branch from 7d1ba83 to 8110bb2 Compare May 22, 2017 14:41

azuresdkci assigned markcowl May 22, 2017

Implemeted Usage cmdlet for Network; Added usage tests

e7ce6d9

EvgenyAgafonchikov force-pushed the networkusage branch from 8110bb2 to e7ce6d9 Compare May 23, 2017 14:22

EvgenyAgafonchikov force-pushed the networkusage branch from 168dc44 to e7ce6d9 Compare May 24, 2017 11:58

Regenerated Network help files

3e470a3

EvgenyAgafonchikov changed the title ~~[Do not merge. Test mode] Implemeted Usage cmdlet for Network; Added usage tests~~ Implemeted Usage cmdlet for Network; Added usage tests May 24, 2017

markcowl requested changes May 26, 2017

View reviewed changes

markcowl added needs-revision and removed needs-review labels May 26, 2017

markcowl requested a review from DeepakRajendranMsft May 26, 2017 02:10

markcowl assigned EvgenyAgafonchikov and DeepakRajendranMsft and unassigned markcowl May 26, 2017

Added output type. Filled and regenerated help

91d358e

markcowl requested changes May 30, 2017

View reviewed changes

DeepakRajendranMsft previously approved these changes May 30, 2017

View reviewed changes

Updating of readme with sample output

f995b34

EvgenyAgafonchikov dismissed DeepakRajendranMsft’s stale review via f995b34 May 31, 2017 09:30

cormacpayne unassigned EvgenyAgafonchikov and DeepakRajendranMsft Jun 1, 2017

cormacpayne assigned markcowl and unassigned DeepakRajendranMsft Jun 1, 2017

markcowl previously approved these changes Jun 4, 2017

View reviewed changes

markcowl added Waiting for On Demand and removed needs-revision labels Jun 4, 2017

markcowl changed the base branch from preview to release-4.1.0 June 4, 2017 00:11

Adding json record to test project

fc6f0f8

markcowl dismissed their stale review via fc6f0f8 June 4, 2017 01:48

markcowl approved these changes Jun 4, 2017

View reviewed changes

markcowl merged commit 7674d70 into Azure:release-4.1.0 Jun 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implemeted Usage cmdlet for Network; Added usage tests #4009

Implemeted Usage cmdlet for Network; Added usage tests #4009

Uh oh!

EvgenyAgafonchikov commented May 22, 2017 •

edited

Loading

Uh oh!

msftclas commented May 22, 2017

Uh oh!

azuresdkci commented May 22, 2017

Uh oh!

EvgenyAgafonchikov commented May 23, 2017

Uh oh!

markcowl commented May 24, 2017

Uh oh!

markcowl May 26, 2017

Uh oh!

markcowl May 26, 2017

Uh oh!

markcowl commented May 26, 2017

Uh oh!

markcowl May 30, 2017

Uh oh!

markcowl May 30, 2017

Uh oh!

EvgenyAgafonchikov Jun 1, 2017

Uh oh!

DeepakRajendranMsft commented May 30, 2017

Uh oh!

markcowl Jun 4, 2017

Uh oh!

markcowl commented Jun 4, 2017

Uh oh!

markcowl commented Jun 4, 2017

Uh oh!

Uh oh!

Implemeted Usage cmdlet for Network; Added usage tests #4009

Implemeted Usage cmdlet for Network; Added usage tests #4009

Uh oh!

Conversation

EvgenyAgafonchikov commented May 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

msftclas commented May 22, 2017

Uh oh!

azuresdkci commented May 22, 2017

Uh oh!

EvgenyAgafonchikov commented May 23, 2017

Uh oh!

markcowl commented May 24, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl commented May 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DeepakRajendranMsft commented May 30, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl commented Jun 4, 2017

Uh oh!

markcowl commented Jun 4, 2017

Uh oh!

Uh oh!

EvgenyAgafonchikov commented May 22, 2017 •

edited

Loading