Skip to content

Get-AzureVMSqlServerExtension was not reporting back "AutoBackup" and "AutoPatching" configurations. #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 19, 2015
Merged

Get-AzureVMSqlServerExtension was not reporting back "AutoBackup" and "AutoPatching" configurations. #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3518a23
Merge pull request #15 from Azure/dev
sethusrinivasan Mar 25, 2015
2fc14fb
Merge pull request #16 from Azure/dev
sethusrinivasan Apr 13, 2015
dfbe868
Merge pull request #17 from Azure/dev
sethusrinivasan May 4, 2015
c36c3f1
Merge pull request #18 from Azure/dev
sethusrinivasan May 6, 2015
bc81a61
Merge pull request #19 from Azure/dev
sethusrinivasan May 18, 2015
faddde8
Get-AzureVMSqlServerExtension was not reporting back "AutoBackup" and…
sethusrinivasan May 19, 2015
82bb198
Merge pull request #20 from Azure/dev
sethusrinivasan May 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...pute/Commands.ServiceManagement/IaaS/Extensions/SqlServer/GetAzureVMSqlServerExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ protected override void ProcessRecord()
/// <returns></returns>
private VirtualMachineSqlServerExtensionContext GetExtensionContext(ResourceExtensionReference r)
{
string extensionName= VirtualMachineSqlServerExtensionCmdletBase.ExtensionPublishedNamespace + "."
+ VirtualMachineSqlServerExtensionCmdletBase.ExtensionPublishedName;

VirtualMachineSqlServerExtensionContext context = new VirtualMachineSqlServerExtensionContext
{
ExtensionName = r.Name,
Expand All @@ -90,7 +93,7 @@ private VirtualMachineSqlServerExtensionContext GetExtensionContext(ResourceExte
foreach (NSM.ResourceExtensionStatus res in extensionStatusList)
{
// Expected ReferenceName = "Microsoft.SqlServer.Management.SqlIaaSAgent"
if (!res.HandlerName.Equals(r.ReferenceName, System.StringComparison.InvariantCulture))
if (!res.HandlerName.Equals(extensionName, System.StringComparison.InvariantCulture))
{
// skip all non-sql extensions
continue;
Expand Down
2 changes: 1 addition & 1 deletion ...pute/Commands.ServiceManagement/IaaS/Extensions/SqlServer/SetAzureVMSqlServerExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ internal void ExecuteCommand()
protected override void ValidateParameters()
{
base.ValidateParameters();
this.ReferenceName = string.IsNullOrEmpty(this.ReferenceName) ? ExtensionDefaultName : this.ReferenceName;
this.ReferenceName = string.IsNullOrEmpty(this.ReferenceName) ? ExtensionPublishedName : this.ReferenceName;
this.SetupAutoTelemetrySettings();
this.PublicConfiguration = GetPublicConfiguration();
this.PrivateConfiguration = GetPrivateConfiguration();
Expand Down
8 changes: 4 additions & 4 deletions ...ServiceManagement/IaaS/Extensions/SqlServer/VirtualMachineSqlServerExtensionCmdletBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ public class VirtualMachineSqlServerExtensionCmdletBase : VirtualMachineExtensio
/// <summary>
/// Extension's publisher name
/// </summary>
protected const string ExtensionDefaultPublisher = "Microsoft.SqlServer.Management";
protected const string ExtensionPublishedNamespace = "Microsoft.SqlServer.Management";

/// <summary>
/// Extension's name -
/// </summary>
protected const string ExtensionDefaultName = "SqlIaaSAgent";
protected const string ExtensionPublishedName = "SqlIaaSAgent";

/// <summary>
/// Extension's default version
Expand All @@ -60,8 +60,8 @@ public class VirtualMachineSqlServerExtensionCmdletBase : VirtualMachineExtensio
/// </summary>
public VirtualMachineSqlServerExtensionCmdletBase()
{
base.publisherName = ExtensionDefaultPublisher;
base.extensionName = ExtensionDefaultName;
base.publisherName = ExtensionPublishedNamespace;
base.extensionName = ExtensionPublishedName;
}

/// <summary>
Expand Down