-
Notifications
You must be signed in to change notification settings - Fork 4k
Azure Analysis Services: added new sku and scale up/down support #4013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@igor-uzhviev, |
Can one of the admins verify this patch? |
@azuresdkci add to whitelist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change in the test. Also, please describe the customer impact of this change in the changelog for analysis services
{ | ||
param | ||
( | ||
$location = "West US" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shoudls et the location based on the availability of the RP in the location and not to a hard-code value. Ths prevents using this test against the test cluster, sovereign clouds, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the change log.
Sent you an email with questions about location. It is not really clear what and how should be implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added GetLocation as discussed by email.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One monir change to the changelog, otherwise LGTM
## Version 0.2.0 | ||
|
||
## Version 0.1.0 | ||
## Version 0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just add this under 'Current release and leave the version number as is
@igor-uzhviev note: if yopu just change the changelog, the on demand run will not need to be rerun |
@markcowl change log is fixed. please verify. |
Description
Added new SKUs for Azure Analysis Services, added support of scale down/up.
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines