-
Notifications
You must be signed in to change notification settings - Fork 4k
add new property for bgp #4021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new property for bgp #4021
Conversation
@@ -36,6 +36,9 @@ public class NewAzureBGPPeeringCommand : ExpressRouteBaseCmdlet | |||
HelpMessage = "Peer Asn")] | |||
public UInt32 PeerAsn { get; set; } | |||
|
|||
[Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "Legacy Mode")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this parameter value really come from the pipeline? What, exactly does LegacyMode mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add at least one test for the new property
@markcowl, test added and updated help.xml for new parameters. The new field is to let server side know whether the server should main old behavior for the customer or change the behavior to new behavior. I am not sure whether we need value from the pipeline , I followed other parameters in our cmdlets. |
@markcowl , the customer can get the object from getting a call and use it to other new or set call. In this case, we will need value from the pipeline, right? I also added the default value for this new parameter since it is an optional parameter and when the customer does not specify it, it will have a default value. |
@dihan0604 There are merge conflicts, please update |
@markcowl , merge conflict addressed |
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines