-
Notifications
You must be signed in to change notification settings - Fork 4k
New CrossConnection commandlets and additional parameters to BgpPeering commandlets #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bc9e8b8
Updated ExpressRoute commandlets to latest Hydra specs
brooklyngw 7d08c4f
Merge branch 'dev' of https://github.com/Azure/azure-powershell.git i…
brooklyngw 684ef3a
Merge branch 'dev' of https://github.com/Azure/azure-powershell.git i…
brooklyngw 6ebdab8
Minor fixes to new crossconnection commandlets and AzureBgpPeering co…
brooklyngw cdab3eb
Merge branch 'dev' of https://github.com/Azure/azure-powershell.git i…
brooklyngw 5415967
Minor Fixes
brooklyngw 3c5fe48
Merge branch 'dev' of https://github.com/Azure/azure-powershell.git i…
brooklyngw 4369a37
Removed app.config from Commands.Test.csproj
brooklyngw 834f6bb
Fixing build errors
brooklyngw 7071e98
Converting ServiceKey and AuthorizationId to Guid
brooklyngw 6e8e47e
Removed unnecessary file and also fixed missing line in azurepowershe…
brooklyngw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
...Management/ExpressRoute/Commands.ExpressRoute/CrossConnections/GetAzureCrossConnection.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| // ---------------------------------------------------------------------------------- | ||
| // | ||
| // Copyright Microsoft Corporation | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // ---------------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| using System.Collections.Generic; | ||
| using System.Management.Automation; | ||
| using Microsoft.WindowsAzure.Management.ExpressRoute.Models; | ||
|
|
||
| namespace Microsoft.WindowsAzure.Commands.ExpressRoute | ||
| { | ||
| using System; | ||
|
|
||
| [Cmdlet(VerbsCommon.Get, "AzureCrossConnection"), OutputType(typeof(AzureCrossConnection), typeof(IEnumerable<AzureCrossConnection>))] | ||
| public class GetAzureCrossConnectionCommand : ExpressRouteBaseCmdlet | ||
| { | ||
| [Parameter(Position = 0, Mandatory = false, ValueFromPipelineByPropertyName = true, | ||
| HelpMessage = "Service Key representing the Dedicated Circuit")] | ||
| public Guid ServiceKey { get; set; } | ||
|
|
||
| public override void ExecuteCmdlet() | ||
| { | ||
| if(ServiceKey != Guid.Empty) | ||
| { | ||
| GetByServiceKey(); | ||
| } | ||
| else | ||
| { | ||
| GetNoServiceKey(); | ||
| } | ||
| } | ||
|
|
||
| private void GetByServiceKey() | ||
| { | ||
| var crossConnection = ExpressRouteClient.GetAzureCrossConnection(ServiceKey); | ||
| WriteObject(crossConnection); | ||
| } | ||
|
|
||
| private void GetNoServiceKey() | ||
| { | ||
| var crossConnections = ExpressRouteClient.ListAzureCrossConnections(); | ||
| WriteObject(crossConnections, true); | ||
| } | ||
| } | ||
| } | ||
|
|
48 changes: 48 additions & 0 deletions
48
...anagement/ExpressRoute/Commands.ExpressRoute/CrossConnections/NewAzureCrossConnections.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // ---------------------------------------------------------------------------------- | ||
| // | ||
| // Copyright Microsoft Corporation | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // ---------------------------------------------------------------------------------- | ||
|
|
||
| using System; | ||
| using System.Management.Automation; | ||
| using Microsoft.WindowsAzure.Commands.ExpressRoute.Properties; | ||
| using Microsoft.WindowsAzure.Management.ExpressRoute.Models; | ||
|
|
||
| namespace Microsoft.WindowsAzure.Commands.ExpressRoute | ||
| { | ||
| [Cmdlet(VerbsCommon.New, "AzureCrossConnection"), OutputType(typeof(AzureCrossConnection))] | ||
| public class NewAzureCrossConnectionCommand : ExpressRouteBaseCmdlet | ||
| { | ||
| [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, | ||
| HelpMessage = "Dedicated Circuit Service Key")] | ||
| public Guid ServiceKey { get; set; } | ||
|
|
||
| [Parameter(HelpMessage = "Do not confirm Azure Cross Connection creation")] | ||
| public SwitchParameter Force { get; set; } | ||
|
|
||
| public override void ExecuteCmdlet() | ||
| { | ||
| ConfirmAction( | ||
| Force.IsPresent, | ||
| string.Format(Resources.NewAzureCrossConnectionWarning, ServiceKey), | ||
| string.Format(Resources.NewAzureCrossConnectionMessage, ServiceKey), | ||
| ServiceKey.ToString(), | ||
| () => | ||
| { | ||
| var crossConnection = ExpressRouteClient.NewAzureCrossConnection(ServiceKey); | ||
| WriteVerboseWithTimestamp(Resources.NewAzureCrossConnectionSucceeded); | ||
| WriteObject(crossConnection); | ||
| }); | ||
|
|
||
| } | ||
| } | ||
| } |
49 changes: 49 additions & 0 deletions
49
...Management/ExpressRoute/Commands.ExpressRoute/CrossConnections/SetAzureCrossConnection.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| // ---------------------------------------------------------------------------------- | ||
| // | ||
| // Copyright Microsoft Corporation | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // ---------------------------------------------------------------------------------- | ||
|
|
||
| using System; | ||
| using System.ComponentModel; | ||
| using System.Management.Automation; | ||
| using Microsoft.WindowsAzure.Commands.ExpressRoute.Properties; | ||
| using Microsoft.WindowsAzure.Management.ExpressRoute.Models; | ||
|
|
||
| namespace Microsoft.WindowsAzure.Commands.ExpressRoute | ||
| { | ||
|
|
||
| [Cmdlet(VerbsCommon.Set, "AzureCrossConnection"), OutputType(typeof(AzureCrossConnection))] | ||
| public class SetAzureCrossConnectionCommand : ExpressRouteBaseCmdlet | ||
| { | ||
| [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "Service Key representing Azure Circuit for which BGP peering needs to be created/modified")] | ||
| public Guid ServiceKey { get; set; } | ||
|
|
||
| [Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "Notification Operation to perform. NotifyCrossConnectionProvisioned or NotifyCrossConnectionNotProvisioned")] | ||
| [ValidateNotNullOrEmpty] | ||
| public UpdateCrossConnectionOperation Operation { get; set; } | ||
|
|
||
| [Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "Provisioning Error Message")] | ||
| public string ProvisioningError { get; set; } | ||
|
|
||
| [Parameter(Mandatory = false)] | ||
| public SwitchParameter PassThru { get; set; } | ||
|
|
||
| public override void ExecuteCmdlet() | ||
| { | ||
| var crossConnection = ExpressRouteClient.SetAzureCrossConnection(ServiceKey, new CrossConnectionUpdateParameters() {Operation = Operation, ProvisioningError = ProvisioningError}); | ||
| if(PassThru.IsPresent) | ||
| { | ||
| WriteObject(crossConnection); | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: fix alignment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed