Ritwikbpreview - Expose new SKUs for VPN gateways #4039

ritwikbasu · 2017-05-26T21:27:51Z

Description

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

[Y] I have read the contribution guidelines.
[Y] If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
[N/A] If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

[Y] Title of the pull request is clear and informative.
[Y] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
[Y] The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

[Y] Pull request includes test coverage for the included changes.
[Y] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

[N/A] New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
[Y] Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

[Y] Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
[Y] Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
[Y] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

…bpreview

Add documentation changes for new Vpn Gateway SKUs

msftclas · 2017-05-26T21:27:54Z

@ritwikbasu,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

azuresdkci · 2017-05-26T21:30:10Z

Can one of the admins verify this patch?

markcowl · 2017-05-27T00:42:29Z

src/Common/Commands.Common.Authentication/Commands.Common.Authentication.csproj

@@ -72,7 +72,7 @@
      <Private>True</Private>
    </Reference>
    <Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
-      <HintPath>..\..\packages\Microsoft.Rest.ClientRuntime.2.3.5\lib\net45\Microsoft.Rest.ClientRuntime.dll</HintPath>
+      <HintPath>..\..\packages\Microsoft.Rest.ClientRuntime.2.3.6\lib\net45\Microsoft.Rest.ClientRuntime.dll</HintPath>


Please use version 2.3.8

Fixed - I just imported the latest version of azure sdk, and this was added automatically.

markcowl · 2017-05-27T00:42:39Z

src/ResourceManager/Network/Commands.Network.Test/Commands.Network.Test.csproj

@@ -201,6 +201,7 @@
    <None Include="..\..\Common\Commands.ScenarioTests.ResourceManager.Common\AzureRM.Storage.ps1">
      <Link>ScenarioTests\AzureRM.Storage.ps1</Link>
    </None>
+    <None Include="app.config" />


markcowl · 2017-05-27T00:44:09Z

...nager/Network/Commands.Network/VirtualNetworkGateway/NewAzureVirtualNetworkGatewayCommand.cs

@@ -216,9 +219,25 @@ private PSVirtualNetworkGateway CreateVirtualNetworkGateway()
                }
            }

-            if (this.EnableActiveActiveFeature.IsPresent && !vnetGateway.Sku.Tier.Equals(MNM.VirtualNetworkGatewaySkuTier.HighPerformance))
+            if (this.EnableActiveActiveFeature.IsPresent 


Tests for these changes? Also, please update the Changelog.md for Network to reflect the changes

These are covered by the existing tests - since this change is just adding new enums to already existing objects. There is no business logic change here.

Updated changelog md for network to reflect this.

markcowl · 2017-05-27T00:48:06Z

@DeepakRajendranMsft Please add this one to the review list as well

Incorating review comments

DeepakRajendranMsft · 2017-05-30T21:33:12Z

src/ResourceManager/Network/Commands.Network/Commands.Network.csproj

@@ -90,7 +90,7 @@
      <HintPath>..\..\..\packages\Microsoft.Data.Services.Client.5.6.4\lib\net40\Microsoft.Data.Services.Client.dll</HintPath>
    </Reference>
    <Reference Include="Microsoft.Rest.ClientRuntime, Version=2.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
-      <HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.2.3.5\lib\net45\Microsoft.Rest.ClientRuntime.dll</HintPath>
+      <HintPath>..\..\..\packages\Microsoft.Rest.ClientRuntime.2.3.6\lib\net45\Microsoft.Rest.ClientRuntime.dll</HintPath>


we have used 2.3.8 everywhere. why in network project alone, we use 2.3.6?

If possible, we should use 2.3.6 everywhere

This has already been changed in the latest commit.

DeepakRajendranMsft · 2017-05-30T21:34:30Z

...nager/Network/Commands.Network/VirtualNetworkGateway/NewAzureVirtualNetworkGatewayCommand.cs

            {
-                throw new ArgumentException("Virtual Network Gateway Sku should be " + MNM.VirtualNetworkGatewaySkuTier.HighPerformance + " when Active-Active feature flag is set to True.");
+                throw new ArgumentException("Virtual Network Gateway Sku should be " + MNM.VirtualNetworkGatewaySkuTier.Basic + " when VpnType is PolicyBased.");


we should not have any validations here. the server should handle all validations

DeepakRajendranMsft · 2017-05-30T21:39:03Z

...nager/Network/Commands.Network/VirtualNetworkGateway/NewAzureVirtualNetworkGatewayCommand.cs

+                && !vnetGateway.Sku.Tier.Equals(MNM.VirtualNetworkGatewaySkuTier.VpnGw2)
+                && !vnetGateway.Sku.Tier.Equals(MNM.VirtualNetworkGatewaySkuTier.VpnGw3))
+            {
+                string errorMessage = string.Format(


dont have any validations here. make sure the user can see the server error message

DeepakRajendranMsft · 2017-05-30T21:40:01Z

...er/Network/Commands.Network/VirtualNetworkGateway/ResizeAzureVirtualNetworkGatewayCommand.cs

            {
-                throw new ArgumentException("Virtual Network Gateway Sku should be " + MNM.VirtualNetworkGatewaySkuTier.HighPerformance + " when Active-Active feature is already enabled on gateway.");
+                throw new ArgumentException("Cannot resize gateway from V1 gateway sizes (Default/Standard/HighPerformance) to V2 gateway sizes (VpnGw1/VpnGw2/VpnGw3)");


similar comment: please dont have any server side validations on PS.

DeepakRajendranMsft · 2017-05-30T21:40:15Z

...er/Network/Commands.Network/VirtualNetworkGateway/UpdateAzureVirtualNetworkGatewayCommand.cs


                if (activeActiveSkuCriteria)
                {
-                    throw new ArgumentException("Virtual Network Gateway Sku should be " + MNM.VirtualNetworkGatewaySkuTier.HighPerformance + " when Active-Active feature flag is set to True.");
+                    string errorMessage = string.Format(
+                    "Virtual Network Gateway Sku should be one of {0}/{1}/{2}/{3} when Active-Active feature flag is set to True.",


similar comment on error message

DeepakRajendranMsft · 2017-05-30T21:41:03Z

src/ResourceManager/Network/Commands.Network/packages.config

@@ -18,7 +18,7 @@
  <package id="Microsoft.Data.OData" version="5.6.4" targetFramework="net45" />
  <package id="Microsoft.Data.Services.Client" version="5.6.4" targetFramework="net45" />
  <package id="Microsoft.Net.Http" version="2.2.28" targetFramework="net45" />
-  <package id="Microsoft.Rest.ClientRuntime" version="2.3.5" targetFramework="net45" />
+  <package id="Microsoft.Rest.ClientRuntime" version="2.3.8" targetFramework="net452" />


why net452 and not just net45?

would 2.3.6 use just net45? if thats the case, lets use 2.3.6 instead

This was auto changed when pulling latest nuget - so leaving it in.

DeepakRajendranMsft · 2017-05-30T21:41:25Z

@markcowl @ritwikbasu i have added my comments

Remove server side validations from PS

cormacpayne · 2017-06-01T16:55:15Z

@DeepakRajendranMsft any other comments?

ritwikbasu · 2017-06-02T18:37:23Z

Hello - can you please let me know if there are any other comments/suggestions?

markcowl · 2017-06-04T00:29:51Z

@azuresdkci add to whitelist

All comments resolved

markcowl · 2017-06-04T00:32:00Z

on demand run here: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-demand/1644/

ritwikbasu added 3 commits May 24, 2017 14:23

Expose new skus for Vpn gateways

f8241e7

Merge remote-tracking branch 'refs/remotes/Azure/preview' into ritwik…

2c351be

…bpreview

Add documentation changes for new Vpn Gateway SKUs

e0e19b0

Add documentation changes for new Vpn Gateway SKUs

msftclas added the cla-not-required label May 26, 2017

azuresdkci added the needs-review label May 26, 2017

azuresdkci assigned markcowl May 26, 2017

markcowl requested changes May 27, 2017

View reviewed changes

markcowl requested a review from DeepakRajendranMsft May 27, 2017 00:47

markcowl removed their assignment May 27, 2017

Incorating review comments

66b68b0

Incorating review comments

markcowl assigned DeepakRajendranMsft May 30, 2017

DeepakRajendranMsft previously requested changes May 30, 2017

View reviewed changes

Incorporating Review changes

dd5eb8e

Remove server side validations from PS

markcowl approved these changes Jun 4, 2017

View reviewed changes

markcowl changed the base branch from preview to release-4.1.0 June 4, 2017 00:30

markcowl unassigned DeepakRajendranMsft Jun 4, 2017

markcowl added Waiting for On Demand and removed needs-review labels Jun 4, 2017

markcowl merged commit 0295f92 into Azure:release-4.1.0 Jun 4, 2017

Ritwikbpreview - Expose new SKUs for VPN gateways #4039

Ritwikbpreview - Expose new SKUs for VPN gateways #4039

Uh oh!

Conversation

ritwikbasu commented May 26, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

msftclas commented May 26, 2017

Uh oh!

azuresdkci commented May 26, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markcowl commented May 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DeepakRajendranMsft commented May 30, 2017

Uh oh!

cormacpayne commented Jun 1, 2017

Uh oh!

ritwikbasu commented Jun 2, 2017

Uh oh!

markcowl commented Jun 4, 2017

Uh oh!

markcowl commented Jun 4, 2017

Uh oh!

Uh oh!

ritwikbasu commented May 26, 2017 •

edited by azuresdkci

Loading