Skip to content

add pagination support #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2017

Conversation

DeepakRajendranMsft
Copy link
Contributor

@DeepakRajendranMsft DeepakRajendranMsft commented Jun 10, 2017

Description

Changes contain:

  1. add pagination support for GET (list) commands
  2. minor bug fix in GET NIC (format.xml)
  3. removing redundant code

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.


var nextPageLink = this.AddResourceToListAndReturnNextPageLink(resourcePage, resourceList);

while (!string.IsNullOrEmpty(nextPageLink))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markcowl please take a look at the changes. i have removed the redundant code.

Copy link
Contributor

@EvgenyAgafonchikov EvgenyAgafonchikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cormacpayne cormacpayne assigned markcowl and unassigned cormacpayne Jun 13, 2017
@DeepakRajendranMsft
Copy link
Contributor Author

@markcowl could you please take another look

@markcowl
Copy link
Member

Waiting on common code implementation for SupportsPaging

Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeepakRajendranMsft LGTM

Does this PR contain all of the cmdlets that would need to use this new mechanism? Also, any additional test coverage needed for these changes?

@cormacpayne
Copy link
Member

@DeepakRajendranMsft
Copy link
Contributor Author

DeepakRajendranMsft commented Jun 26, 2017

@cormacpayne, As mentioned above, the problem was that to test it, we would require to create a lot of resources. and yes we have all the cmdlets that would use this. i tested this manually against our test clusters

@cormacpayne cormacpayne dismissed markcowl’s stale review June 26, 2017 23:26

Mark is OOF, approved offline with Scott

@cormacpayne cormacpayne merged commit 6c03ba4 into Azure:preview Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants