-
Notifications
You must be signed in to change notification settings - Fork 4k
Cognitive Services PS 1.0.0 #4113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cognitive Services PS 1.0.0 #4113
Conversation
1. Makes reference to Cognitive Services SDK 1.0.0. Also changes some code accordingly. 2. Re-records all test cases. 3. Fixes an account length bug. 4. Reversions to 1.0.0
1. Makes reference to Cognitive Services SDK 1.0.0. Also changes some code accordingly. 2. Re-records all test cases. 3. Fixes an account length bug. 4. Reversions to 1.0.0
…wa/azure-powershell into CognitiveServices-PS-1.0.0
@cormacpayne , ping, this has been here 2 days...these are not complicated changes. |
@felixwa Hey Felix, our SLA for reviewing pull requests is two business days, so I will take a look at this in the morning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixwa LGTM
Please update the change log and this will be ready to merge
Revision ChangeLog.md to 1.0.0
@cormacpayne , thanks, I have updated changelog.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixwa I updated your branch with the correct change to the change log. I will merge this once CI passes
@cormacpayne , thanks! I see what the correct format of change log now. |
code accordingly.
Description
This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.
General Guidelines
Testing Guidelines
Cmdlet Signature Guidelines
ShouldProcess
and haveSupportShouldProcess=true
specified in the cmdlet attribute. You can find more information onShouldProcess
here.OutputType
attribute if any output is produced - if the cmdlet produces no output, it should implement aPassThru
parameter.Cmdlet Parameter Guidelines