Skip to content

Cognitive Services PS 1.0.0 #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2017

Conversation

felixwa
Copy link
Contributor

@felixwa felixwa commented Jun 12, 2017

  1. Makes reference to Cognitive Services SDK 1.0.0. Also changes some
    code accordingly.
  2. Re-records all test cases.
  3. Fixes an account length bug.
  4. Reversions to 1.0.0

Description


This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
  • The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

  • New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
  • Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

  • Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
  • Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
  • Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

1. Makes reference to Cognitive Services SDK 1.0.0. Also changes some
code accordingly.
2. Re-records all test cases.
3. Fixes an account length bug.
4. Reversions to 1.0.0
1. Makes reference to Cognitive Services SDK 1.0.0. Also changes some
code accordingly.
2. Re-records all test cases.
3. Fixes an account length bug.
4. Reversions to 1.0.0
@felixwa
Copy link
Contributor Author

felixwa commented Jun 14, 2017

@cormacpayne , ping, this has been here 2 days...these are not complicated changes.

@cormacpayne
Copy link
Member

@felixwa Hey Felix, our SLA for reviewing pull requests is two business days, so I will take a look at this in the morning

Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixwa LGTM

Please update the change log and this will be ready to merge

Revision ChangeLog.md to 1.0.0
@felixwa
Copy link
Contributor Author

felixwa commented Jun 15, 2017

@cormacpayne , thanks, I have updated changelog.md.

Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixwa I updated your branch with the correct change to the change log. I will merge this once CI passes

@cormacpayne cormacpayne merged commit d1eab7f into Azure:preview Jun 16, 2017
@felixwa
Copy link
Contributor Author

felixwa commented Jun 16, 2017

@cormacpayne , thanks! I see what the correct format of change log now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants